From: Yongseok Koh <yskoh@mellanox.com>
To: shahafs@mellanox.com
Cc: stable@dpdk.org, Yongseok Koh <yskoh@mellanox.com>
Subject: [dpdk-stable] [PATCH 17.11] net/mlx5: fix return value when deleting fdir filter
Date: Thu, 16 Aug 2018 11:59:24 -0700 [thread overview]
Message-ID: <20180816185924.7681-1-yskoh@mellanox.com> (raw)
rte_errno may have garbage value if there's no error.
Fixes: 7075f007b361 ("net/mlx5: standardize on negative errno values")
Fixes: 8e47ba2b073a ("net/mlx5: fix error number handling")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 7e4b84292..7e69f6aba 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -3001,9 +3001,11 @@ mlx5_fdir_filter_delete(struct rte_eth_dev *dev,
if (parser.queue[i].ibv_attr)
rte_free(parser.queue[i].ibv_attr);
}
- if (ret)
+ if (ret) {
rte_errno = ret; /* Restore rte_errno. */
- return -rte_errno;
+ return -rte_errno;
+ }
+ return 0;
}
/**
--
2.11.0
next reply other threads:[~2018-08-16 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 18:59 Yongseok Koh [this message]
2018-08-16 19:01 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816185924.7681-1-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).