From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by dpdk.org (Postfix) with ESMTP id 3970A4C87 for ; Thu, 16 Aug 2018 21:10:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t1ngYxm1AuCKywf5++A6VGXY1UVJpDAaJ0jWU+vbh5U=; b=QwwqszPPMym9A0cl4LS1+q/1IFusZlJgmy4vX+1E4e1UySISwCYQ7+DJC+OBgvryI/7IYZwH3fj4GaziqLAP+cASAPIagoGsev6eWKWHfRimgHgDmhxzcivCf64+DfSJVFhdbIb4VE247j8rioibhCJ40zC6tTY0UzCR8C5uSRo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.20; Thu, 16 Aug 2018 19:10:14 +0000 From: Yongseok Koh To: christian.ehrhardt@canonical.com Cc: stable@dpdk.org, shahafs@mellanox.com, Yongseok Koh Date: Thu, 16 Aug 2018 12:09:57 -0700 Message-Id: <20180816190957.35232-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR2001CA0034.namprd20.prod.outlook.com (2603:10b6:405:16::20) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4766498-3417-400d-bdb1-08d603abe5ff X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3980; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 3:bvSCzPc8xXxLvbDMoLKVSp7M1SGFKukWp1KbmVwSBQMS8+M71Er8LqpGfuj17Q9j4emIqQC84m9dCGWU4sgmf2uX4NJEVTGEcAep4pW1EdVRgVCul0veWNyHuitU9NWMy+zsTcESgjcCejTcRC/MtFXRgFuhKuZFmoryimj3Qy/7JeepnVv46geSk2T13TnJdfpVRlYKF8pQv3YZosTaGvgNO7yeDSeDhmEC1bwKOk3n8oy0UQt8fAZueGLbcpb8; 25:zZEXzgjY6McS2jgGoWN1C0AWGhaLWFBvU6D4I0YMFBb8UYS4jVefXvwGK6Wt0DkV6h54aOmLhyaN5rnE2zvPNnbzKOuUmCNckpO+nytUCK/AsclWc+xIsAu+T3iH60vQ3huxWR+lYig4S0XvK4oQqMJ/Q1E+OivZGEjdXGp4Detlriah64xL4pkV53jZhoLqjOmLZXrgLxHpZu+3cTGfV1X+6oK5S84L+9ocicXyq1PMCLvIfWW1C4hmCmqOC/Iuv1AUty6uTRArktkA2KKVjyOEH6Vfto54nLgCNBtpvCiHbmU07O+c5AbSQkOK7xX7fEZw6T8m6pzvUt26QssmLA==; 31:r1ShH3urttGmfeP2mcjRVTe19EsqA6hhLnZa/MbJ7ehyxbaqYk6mqRQV6MhPJXHAm4Zlxcw45u9GbHqGX6yH6GAEPLQuxB3QkrvO577oFZSuuKWWl/GNLAMiVGB8jTJDIOQ4luv88OcxjcrikBNKV3CAIeGs/VvseA6yKy1KnGzoPAhHbBQYpwqvqz2sfEkRkYziITB3s5exK2ntxHOp3KYCyvo6p4aEnlbZGDsQFtI= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3980: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 20:YBJTRy+IwhJR2Tmu8Fh/FfrkVctRtiMwbou13XTqaHSb+f6Kgknreo72v5vi4mVA1ONcyc+Cdg/VWsJ3QwAXCDpV7WDwlF/552XvIgr1Z19ngn+QyoHHW56TzI3JbgIlTtzxTruWeoJhxPOdLGw8gFGEJMqQiqv3W9AczA/DL7ZfPZQe980vfZNM9pGNttDc+7GzBzll/DDUFZzlRVTUiAYf+gPp9GJ7HBHupKR5hCCLlnVGtVcDhXOlRF9Gb+Vrc6Vj+AE2d2pxjFTrH1RVerbK1nq2w3QABkJ9yaZcxydAziBS730RwEgAAp2Xx5Cr9+i3J2x7jjWNEByhEPyH8LdmaOEgb85E6Hc0VzHDdD45mSA8I4b9qhyoMEaOfV7iPaF2epXllaxNVi6k/vOBfBumb4UNqZt+rRH/IVIMev5nyZueAA21uAAUylxlih0VVUi5b0lvdSfpyWguVzKMsxKf1HmJTIYK1EetxOZCdS7wFtKJEgDo5m7JxR2cT0V3; 4:eL9cBZev0O1UWNWghdiwqEY7LmpBUbHyQ3Q8HQ0m4ogPN1MHYbXDOOQK0CAZ0uDfuL9Cp2N7oYoZGluLLl7eNzAD3JHB+bDTobH0ZLHhURpR0fvR7Yq8LEomyHwblzOoLTNCR+H4jtrO1WYK/igDnEBp+tD1vvWSUjhFfeMlOPnaW+XYCPU8Nzsgbm5h+TcDwhbYDJqCVrc7JKyIHEVjMAKQhz6nB2of7hIwAMy9/DaQyjnKAtlagIZuyu0VPo1ODQH3f8EMLaCUds2i373WSA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301050)(93006095)(93001095)(10201501046)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016); SRVR:DB3PR0502MB3980; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3980; X-Forefront-PRVS: 07665BE9D1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(376002)(346002)(136003)(189003)(199004)(50226002)(486006)(36756003)(8676002)(81156014)(386003)(81166006)(956004)(2351001)(316002)(86362001)(14444005)(476003)(305945005)(69596002)(2616005)(478600001)(8936002)(16586007)(16526019)(186003)(107886003)(68736007)(21086003)(26005)(4326008)(6116002)(7736002)(50466002)(3846002)(53936002)(105586002)(55016002)(52116002)(7696005)(1076002)(25786009)(106356001)(51416003)(6916009)(6666003)(2906002)(97736004)(66066001)(2361001)(47776003)(5660300001)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3980; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3980; 23:bLjRyverji3cdE57ndB7ei22hplZnEScMxiBlol?= =?us-ascii?Q?X5gzsNCQPhKWAr0S0vKa2P6r6REwLSfIB8/0ds7tp5ZIJK5xuPPP2RqCmnD6?= =?us-ascii?Q?ZYVOjfQAFmO3bUXmxtLaEXoQhM6BPhzAD+bmbKIV4japBUXBXaWvEWq2w8Lt?= =?us-ascii?Q?FARhXWjdHlj0g7jA7AaPQBZiGXkWTyoVeMMDx2qc+/lijeDQ7rn4bcVpftW/?= =?us-ascii?Q?WCIvZhsiiuAMj6upfIGxEpooz/qdzPaLURVZUnGKroXSFvEn0WyM5mKYsSSy?= =?us-ascii?Q?FhOnYpxq+gTmBJ35i6EmhUU7YL0qRxg/jz8CBm8H470D5qdjXWywzCnuv4SG?= =?us-ascii?Q?CW8dSx+JCnHS1TO8QXBG1A8P9st7c2kEgNEObDbXg1OTtecmKKmwzx9NJm4u?= =?us-ascii?Q?837NIxFv1I0GOLHZQ0rVnTeG07KJ49cK5mf8HBNMcjHdhoZ05vxQF2qCzeDl?= =?us-ascii?Q?BXH+Gs2QYca5umOy7WxL3QpPT9BZrgLdsn1Yd8lL9VjqVp6Kyi+K1vxzm5MS?= =?us-ascii?Q?tmSYoQsrz5Jf6KIw1m4V3CyrNY9RrGl1DZz8Cwzwx17VaEMxwYUzEB2SZClD?= =?us-ascii?Q?jNTfHmE2LmKzJqfoF0oP0cP+0z/MaEzMfW1Lr+6qP0ozn4afhADyYUZi9t+D?= =?us-ascii?Q?oEQPlxUeFmnsoYFN50jN9mV6uqBK1frCWZUN00f8Z+zLmVtm7wSH64mqauxK?= =?us-ascii?Q?43Wd02E7Ha/YQNDaUbDzrfEm/kMXEzEH3U9vLZpZdBLx7hMk4MhkOxHEUplK?= =?us-ascii?Q?LryQqfOIxMgqRNyf3BHIPNhcD1BB9mA6WL7xyUBI+hjH21/HEF+HbLBUkQFZ?= =?us-ascii?Q?CSz6G9JoUWVL4I04FLXkJ8+DqjawkSV40VNhsRK28w0ayadeaiNtUvcA3o37?= =?us-ascii?Q?Edrk0pLi78w/eqcwWT2N6KdoqpE0ncF60OJ50XlhewKKIxLSI1WOnkunAL6M?= =?us-ascii?Q?LyCOQwylXCOR+ZFc3MSxhYBqS9A3RWKwNKoZWkJ7w8nGHlocbVkzkUKsBOUU?= =?us-ascii?Q?kWqVRP5PbdPHMiHdSwdEJ6iPnUwk0u9g+nrkaXO+UM3mTqBTyf5QaVS8zXCD?= =?us-ascii?Q?vYNIs4s+H5zhoWChcYKYvj1tFQ5/dlCi7AGDBzDLhVoj3v+CE5+NuGZgusCy?= =?us-ascii?Q?ZpBdC5PeFlpmWynWuC6L4KXi2zoFP2VrHGV04cdNnofPqLdFBl85lQAsL4YZ?= =?us-ascii?Q?w1PBLZdz+chYurEMqUemRwi+epk28aopJVSx6ZGfvYFaWNyoaal1O4bQsvw?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Antispam-Message-Info: uYcT9RdVZ46mKdnm1GENSbnEMW0wnHqGLiOXa+RFfu+2NzwLbtV85wygBWLmMOD2LtzNy7xtnRmcC6VITEcjd228lZOE8RPaQ7Bxr5JdLbR0lgn3IAF1PhnXXXS3T8h1HFt5fLLXJYAi54P5zPp+mOQB/vkliv2H4zZnXEbhs5fDTFQzrs+tL1Jjbu/gQppSuW7L7qbrMutpOZ7tNZA1fgPhSlW5DDf4RgS4qUHEa6la+1bhaMHdNse5gnP0FG1gSoitUCKwSvtLt1xszu9kSSyLJTd2c5l4Rer0FO/pNrzoWzhGdgJIDKU23YxcwAMmib9EkWeFsFwcbTggoEu3fWt8hJ4qe/DrSIzXoYwCjkQ= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 6:msA36kjKADi3FnuGqHM6oltQ32FT7ytP/xtEzxL8li25ImmmHzW05f6SOAATrQXDI8YskesHE+ztHP0VpDzqtHZOkhBJYTN5NgdsW30ORn8CCB3NmR4+taawbiON1tgey9dBO3xk6iBldz7FoTuk+1vgo242A/tHhr4KFkDB2AiKn2BubHcbh3vUY7W3Xwz31Ra8tyRFWnscHszTR+9HdAmOa06kq55SzYGJepn5bRMJFhGyV5AE7ebod5p2DTZhDUQY8VcGO3LwTPwLUkVJa3nrModoLxxO48uXVHI54HqWWqlEO3uAYBGaUhHZK8U7vJwiYNlM3g1awELX2d/lZot85XkWwc83X9U4uNAjVBgoXHGTeQefHrPso19fFS0pvOqWMtQnrh92zifTxq+noT5tXp9VFNQ/7rpmdRIF8mWcZ/LStijJNY1Ft8a+ZLLCGxLi4ib7WEfmOvcl9ytrbg==; 5:9+thcG8j6OMVQ+fJ2ok9bVI4ITjE+fRRp6xckxzd7TlW+PL2M8RlTRUdE1aYYk7WYFAZNgw0nCREDDUvbqUseRDhFhT59vrO8n1abdN6czuISUPHc3bPJFIREGfQt7gNkuXY89Uxw/NS/TRzplZBXgpNLXAIJBMY0NfhSis5zR4=; 7:V7pIjRL/3mx40EEnNgG/QfziCorvTF/3mNYi4kt0P36JW4I1fDkH8B2JGQ1On88odZ6DRmlwaUGUuSYTo5wuJ5g4DqqtNmoCjmEbSEMvLr0bzBjpU2nrdD8WOQ0bqvIWpBLEihSgJFsQoEZ0zev75WxAkYpFKhIjay1dRiHo90xvUNcuJBlNUlJC768X658QhQF/6pjugR5EJbKZV0FpOmzieKXk6aKXJlK8FN9Fd2va70t5/5MIYDV/dWDO9Fl5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2018 19:10:14.2381 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4766498-3417-400d-bdb1-08d603abe5ff X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3980 Subject: [dpdk-stable] [PATCH 18.05] net/mlx5: fix return value when deleting fdir filter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 19:10:17 -0000 rte_errno may have garbage value if there's no error. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Fixes: e657445767ed ("net/mlx5: fix error number handling") Signed-off-by: Yongseok Koh --- Hi Christian, This patch is to amend "net/mlx5: fix error number handling", which has been already taken in stable/18.05. You can squash this patch to the previous one if you want, but it is also okay to be two separate patches. For 17.11, I found this bug after I released 17.11.4-rc1, so I had to keep it separate though. Thanks, Yongseok drivers/net/mlx5/mlx5_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 45207d70e..b219a1cad 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -3570,9 +3570,11 @@ mlx5_fdir_filter_delete(struct rte_eth_dev *dev, if (parser.queue[i].ibv_attr) rte_free(parser.queue[i].ibv_attr); } - if (ret) + if (ret) { rte_errno = ret; /* Restore rte_errno. */ - return -rte_errno; + return -rte_errno; + } + return 0; } /** -- 2.11.0