From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 550C03DC for ; Tue, 28 Aug 2018 12:25:32 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id j26-v6so1066160wre.2 for ; Tue, 28 Aug 2018 03:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ArWO2Opf2ZgifVOQFuOXc/1QPOgbUwokmhTEpo4yztM=; b=mqXighgKVIdTlRUacN31Smxk1ZEKOf2lGKvgRJcpzfK8sM6abuvtEVn64OE1DjU6tm fWxcM/puMRT4HL+U3nS6yyB64BXHngmjvuiYmV18pwxHCsZXPGAl8wDjw8S3HuEnUJfd poW8czQcaaIKq9Q05Wn2svdmXrmqK3cekVrNRLURBlmXEmiO5OyVhjgqjNQc57E/ilZN pynYlFV53dlNrvVn5EvcokaDf4zLaD7fizFNrRvKfhOF5Z1gEY9jB+3nPTZEHCvDIqB5 P9y4yN5Vhv90EPQDylDLti5s9aafS/a4DeRm7XuLs9fIbWB1IBq+HAtMXBUnZLokQsDc MWOg== X-Gm-Message-State: APzg51Csw273U7T2R1AM967tS2sdOHU5RDa/ZrvaDW3oBX2A36LrxBCG BfU4r7Op+72nmIH43ZnXMCc= X-Google-Smtp-Source: ANB0VdbYNkNbb2eTjZG1BOXtJLGksA3dLh7iO3P2Q90pre3bdy4paFS0sTzqWeNjgKSdweNj4Nbk2w== X-Received: by 2002:adf:b357:: with SMTP id k23-v6mr705270wrd.207.1535451932082; Tue, 28 Aug 2018 03:25:32 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:41aa:5bfa:6cf3:7531]) by smtp.gmail.com with ESMTPSA id z101-v6sm637170wrb.55.2018.08.28.03.25.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Aug 2018 03:25:31 -0700 (PDT) From: Luca Boccassi To: qi.z.zhang@intel.com Cc: dpdk stable , Luca Boccassi Date: Tue, 28 Aug 2018 11:25:22 +0100 Message-Id: <20180828102522.14500-4-bluca@debian.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180828102522.14500-1-bluca@debian.org> References: <20180810090627.28295-1-luca.boccassi@gmail.com> <20180828102522.14500-1-bluca@debian.org> Subject: [dpdk-stable] patch 'Revert "net/i40e: fix packet count for PF"' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 10:25:32 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/29/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 2a7790e63aaa7ba16d7f8e0d71655228b9b53c03 Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Mon, 27 Aug 2018 10:44:36 +0100 Subject: [PATCH] Revert "net/i40e: fix packet count for PF" This patch introduced a regression in the Fortville regression tests. >>From the tester's report: 1.FVL function test: still have 7 failed. These 7 failed cases are the similar issue: it will send blank packet when it send packet, it caused the packet validate failed. Jumboframes/jumboframes_jumbo_jumbo: could pass with dpdk-stable-16.11.4 Jumboframes/jumboframes_normal_jumbo: same with above Jumboframes/jumboframes_normal_nojumbo: same with above dynamic_config/dynamic_config_enable_promiscuous: same with above pmd/checksum_checking: could pass with dpdk-stable-16.11.3, failed with dpdk-stable-16.11.4 and later versions pmd/packet_checking: same with above This reverts commit 4bf705a7d74b0b4c1d82ad0821c43e32be15a5e5. Signed-off-by: Luca Boccassi --- drivers/net/i40e/i40e_ethdev.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 01f473c2bb..3061296340 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2578,14 +2578,13 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) /* call read registers - updates values, now write them to struct */ i40e_read_stats_registers(pf, hw); - stats->ipackets = ns->eth.rx_unicast + - ns->eth.rx_multicast + - ns->eth.rx_broadcast - - ns->eth.rx_discards - + stats->ipackets = pf->main_vsi->eth_stats.rx_unicast + + pf->main_vsi->eth_stats.rx_multicast + + pf->main_vsi->eth_stats.rx_broadcast - pf->main_vsi->eth_stats.rx_discards; - stats->opackets = ns->eth.tx_unicast + - ns->eth.tx_multicast + - ns->eth.tx_broadcast; + stats->opackets = pf->main_vsi->eth_stats.tx_unicast + + pf->main_vsi->eth_stats.tx_multicast + + pf->main_vsi->eth_stats.tx_broadcast; stats->ibytes = ns->eth.rx_bytes; stats->obytes = ns->eth.tx_bytes; stats->oerrors = ns->eth.tx_errors + -- 2.18.0