From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam02on0042.outbound.protection.outlook.com [104.47.36.42])
by dpdk.org (Postfix) with ESMTP id 75AE954AE;
Tue, 18 Sep 2018 13:00:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=07zGlVLDoY05YOI/7diFgwAS7c6HJEEXe6CbvNLm8tk=;
b=HEySesr9AJecKBYQ1wRuEJuF4QUn/1bor/+RrPPPk4NYsZP/1n9DN0U1TTYpainV+5XSpJjocfXpTZ6VwC/GLlKiahks5U2ikhpLTr6nBPNJVhtxn861/SoOGAtxfL4SKzRvRsciGJKqnBEueigKWw6zIy+hfRV1lbw+7DC8jAY=
Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by
BYAPR07MB5574.namprd07.prod.outlook.com (20.177.231.160) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1143.18; Tue, 18 Sep 2018 11:00:14 +0000
Received: from BYAPR07MB4997.namprd07.prod.outlook.com
([fe80::c465:d2a1:d4ad:3af7]) by BYAPR07MB4997.namprd07.prod.outlook.com
([fe80::c465:d2a1:d4ad:3af7%5]) with mapi id 15.20.1143.017; Tue, 18 Sep 2018
11:00:14 +0000
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Gavin Hu <gavin.hu@arm.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Honnappa.Nagarahalli@arm.com"
<Honnappa.Nagarahalli@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v5] doc: add cross compile part for sample applications
Thread-Index: AQHUTnTAhk8Z6ETk2U2qITSdQeEfuaT14JUA
Date: Tue, 18 Sep 2018 11:00:13 +0000
Message-ID: <20180918110000.GA3278@jerin>
References: <20180917104942.14967-1-gavin.hu@arm.com>
<20180917105343.15434-1-gavin.hu@arm.com>
In-Reply-To: <20180917105343.15434-1-gavin.hu@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [111.93.218.67]
x-clientproxiedby: DM5PR06CA0034.namprd06.prod.outlook.com
(2603:10b6:3:5d::20) To BYAPR07MB4997.namprd07.prod.outlook.com
(2603:10b6:a03:5b::22)
authentication-results: spf=none (sender IP is )
smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; BYAPR07MB5574;
6:RClxxtKXjY6VuezjHaf+hAbg2eo6pX9NgJoXY4wH5q2+l35db9jC7f4VNrmmsuINOGUpL3YB4iAg7N/bVT2aix+ncE5wrnvyau/Qtl+G3PN6j0I5AI4n5g551wnpkbX9ANZbtpsECmr9MLByD0a8LHTLnFMtr+bDX31ppnsrHmpLqcbHtLTvptzjN9uRuD2tb6Mk1AhuG35jXkC40O22g8CNfhdtPtim9urF+ZothxN10z3tLGJjhtloHsZWaxYOkYlHdeuJaUmV2k7sAQtgu+NVqmKdjHE+77peL6Zv6bO8o28URZ/a7+Ctdl3RsIjrz29Y0oYO++tzwne4kAKKYV027smMzEHG5V7rshdzrBP4DdRNxiI26Wuh84bxqZf7NLpNxcKZNC/O2jYypNRhOML0jNFruTZN56wvYmoR8eUJ6nzhNIDtzjHfv4kAgJQJ7c35YsNkwSwwThJGwXjvHA==;
5:ehM3bZDYMv9guYhM2x27pzKp+sJPZlp/1eQ4T4kGepbrd/5FXqNgu0crHHz4Fki4OTBpscNxhMAYJj15g4mSAWGjbiPPCoK+01rbfNKPzikA0mF1WQjjPK7cegdONz7HJOKoWiDaoB6Y93JW1B1ItSWXswBRunsJ/ZwQ2WVBCUw=;
7:Z9tPeoPiGJY8Yu7silijW/PA8BJgVhgyxcjGuDmoknaL+Hd5BImvA8jdf3FwcmRE4YKa+WQLpXdFZ/3BuBQKGlS10tNisKr0Y4HvoeMRS8OmYkII+Sw64tUX49VkXsvgYhBFgmRqfYBe+nPYHhuY24s939wNvtes0Z54P+q4X4czttLlSGexaJJQsilqreX0WY16zaYzl3R0PKO7JNV+aFadHSHduQOa208jhY5k6rMaN4nT1N5EFzOt5lOtjzcu
x-ms-office365-filtering-correlation-id: 0d34fbca-0d49-4c5c-7c49-08d61d55e881
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);
SRVR:BYAPR07MB5574;
x-ms-traffictypediagnostic: BYAPR07MB5574:
x-microsoft-antispam-prvs: <BYAPR07MB5574DB79C1409221F74D5897E31D0@BYAPR07MB5574.namprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(180628864354917)(278428928389397);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3002001)(3231355)(944501410)(52105095)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699050);
SRVR:BYAPR07MB5574; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5574;
x-forefront-prvs: 0799B1B2D7
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(7916004)(346002)(136003)(376002)(39860400002)(396003)(366004)(199004)(189003)(13464003)(11346002)(54906003)(316002)(26005)(186003)(97736004)(6916009)(81166006)(68736007)(81156014)(5660300001)(305945005)(33896004)(76176011)(99286004)(8936002)(2900100001)(476003)(33716001)(14444005)(52116002)(6116002)(1076002)(102836004)(3846002)(42882007)(5250100002)(6506007)(386003)(446003)(53936002)(486006)(256004)(14454004)(229853002)(6486002)(72206003)(6436002)(478600001)(9686003)(6512007)(106356001)(105586002)(2906002)(33656002)(4326008)(6246003)(8676002)(25786009)(7736002)(66066001);
DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5574;
H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
x-microsoft-antispam-message-info: uTEDIlcAYEjRw4c2CC31HEZzjuPZnp1UCngqd1RCD+ETLz+k80mG3QzZvLfqbU6KauiPTZClwrqxJGZkG9tiDbQ2kwXGGC8dDr4GRhf7NlKiUh7A7HDqdowcQaRXclrwtgXPgmSFgfD5/u/WsBU8sMWFdlnPZtwijULp28napSx19B5NvWiDIarqayEpCcAyGuVOf/E6GaYiWw6jcWWhTYm3/OXp60qf0yCinfc0leK7YZzqWQC1Dcony3qabl0E5iGygN+IpJPbw2M99XRPIJPEOvfmk76JXImNwNyZKRsP4kHDoYQkngjAmjsuuyhXn7cJMuJB9DKWWswaUS8CCCBqFT69DIE7ecI9gCjpIME=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2100BA8361D57947B801C7241F797B37@namprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d34fbca-0d49-4c5c-7c49-08d61d55e881
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2018 11:00:13.8866 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5574
Subject: Re: [dpdk-stable] [PATCH v5] doc: add cross compile part for sample
applications
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 11:00:16 -0000
-----Original Message-----
> Date: Mon, 17 Sep 2018 18:53:43 +0800
> From: Gavin Hu <gavin.hu@arm.com>
> To: dev@dpdk.org
> CC: gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com,
> jerin.jacob@caviumnetworks.com, stable@dpdk.org
> Subject: [PATCH v5] doc: add cross compile part for sample applications
> X-Mailer: git-send-email 2.11.0
>=20
> External Email
>=20
> Fixes: 7cacb05655 ("doc: add generic build instructions for sample apps")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> doc/guides/sample_app_ug/compiling.rst | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>=20
> diff --git a/doc/guides/sample_app_ug/compiling.rst b/doc/guides/sample_a=
pp_ug/compiling.rst
> index a2d75ed22..9ff531906 100644
> --- a/doc/guides/sample_app_ug/compiling.rst
> +++ b/doc/guides/sample_app_ug/compiling.rst
> @@ -9,7 +9,6 @@ This section explains how to compile the DPDK sample appl=
ications.
> To compile all the sample applications
> --------------------------------------
>=20
> -
> Set the path to DPDK source code if its not set:
>=20
> .. code-block:: console
> @@ -93,3 +92,18 @@ Build the application:
>=20
> export RTE_TARGET=3Dbuild
> make
> +
> +To cross compile the sample application(s)
> +------------------------------------------
> +
> +For cross compiling the sample application(s), please append 'CROSS=3D$(=
CROSS_COMPILER_PREFIX)' to the 'make' command.
IMO, You can remove "please"
> +In example of AARCH64 cross compiling:
I think, it is better to change to "AARCH64 cross compiling example:"
> +
> + .. code-block:: console
> +
> + export RTE_TARGET=3Dbuild
> + export RTE_SDK=3D/path/to/rte_sdk
> + make -C examples CROSS=3Daarch64-linux-gnu-
> + or
> + cd $(pwd)/examples/<example_app>
Better to change to:
cd $(RTE_SDK)/examples/<example_app>
> + make CROSS=3Daarch64-linux-gnu-
> --
> 2.11.0
With above changes you can add my Acked-by:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>=20