From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <luca.boccassi@gmail.com>
Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com
[209.85.221.51]) by dpdk.org (Postfix) with ESMTP id 41E7E1B109
for <stable@dpdk.org>; Thu, 27 Sep 2018 10:44:22 +0200 (CEST)
Received: by mail-wr1-f51.google.com with SMTP id m16so1605480wrx.12
for <stable@dpdk.org>; Thu, 27 Sep 2018 01:44:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=lT3lcMdzR4Q5zswNnSCMYqJzNDgf3xq1LJyZvD7B+yU=;
b=kwVop2hR3soB07vh0a9b7huZH+dMWMTLiEAPFXZnzF2+6NsXFUzORym6/GkXq9ehaW
ChvaJ5KyoWqfCmqaCGrPd/NAFtxDtxB/7zmtKOeIiBqC2LLQ3xSCshb0vmfj54UMZ1B/
HUao7472oSvwBAjrR04DmZdUVuUZ8hS0shsTF2LGfCeY0i1UXSa/xtM2Bl8fYcKuKQzC
KtvBh4qS8vzigYDx9iQrSxrAw8AdgmBYddPdOU6IuUJCT1/35yzZgZdgZjEufnYsDrYz
57ng8lpfJ5RJtWNTrMvw/OcjdMhjkHO/V3SlcRqNgoOilvxhIv2c1iaRD6c4EOT+MLPa
iYbw==
X-Gm-Message-State: ABuFfoiRgEuwRJs82ojDB67IcMWU1bnmsvZQ+fTNJpgti1LcV59x3A4g
3hJl7ABarxnadVGQgMoWgPA=
X-Google-Smtp-Source: ACcGV60AUiMBV+L5FvJkBROnaam1Od9b++MKkh9VMaxzXkmISzIVeGw68JYi9QAkqbcjef4ORUf8Dw==
X-Received: by 2002:adf:a10c:: with SMTP id
o12-v6mr7998866wro.169.1538037861846;
Thu, 27 Sep 2018 01:44:21 -0700 (PDT)
Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556])
by smtp.gmail.com with ESMTPSA id 124-v6sm2589664wmk.20.2018.09.27.01.44.20
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Thu, 27 Sep 2018 01:44:20 -0700 (PDT)
From: Luca Boccassi <bluca@debian.org>
To: Igor Romanov <igor.romanov@oktetlabs.ru>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
Chas Williams <chas3@att.com>, dpdk stable <stable@dpdk.org>
Date: Thu, 27 Sep 2018 09:44:01 +0100
Message-Id: <20180927084403.19646-6-bluca@debian.org>
X-Mailer: git-send-email 2.18.0
In-Reply-To: <20180927084403.19646-1-bluca@debian.org>
References: <20180927084403.19646-1-bluca@debian.org>
Subject: [dpdk-stable] patch 'net/bonding: use evenly distributed default
RSS RETA' has been queued to LTS release 16.11.9
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 08:44:22 -0000
Hi,
FYI, your patch has been queued to LTS release 16.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/27/18. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Luca Boccassi
---
>>From 79e22e7318fa1f79655765796140261dcfaefa55 Mon Sep 17 00:00:00 2001
From: Igor Romanov <igor.romanov@oktetlabs.ru>
Date: Wed, 29 Aug 2018 08:48:30 +0100
Subject: [PATCH] net/bonding: use evenly distributed default RSS RETA
[ upstream commit 617d1ac2fd22e9a82d305c0607853f4ee0f7277b ]
Default Redirection Table that is set in bonding driver is distributed
evenly over all Rx queues only within every RETA group (the first RETA
entries in every group are always start with zero). But in the most
drivers, default RETA is distributed over all Rx queues without sequence
resets in the beginning of a new group, which implies more balanced
per-core load.
Change the default RETA to be evenly distributed over all Rx queues
considering the whole table.
Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Chas Williams <chas3@att.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 60f9e1ab11..1fe0c179a1 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -2381,7 +2381,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
for (i = 0; i < RTE_DIM(internals->reta_conf); i++) {
internals->reta_conf[i].mask = ~0LL;
for (j = 0; j < RTE_RETA_GROUP_SIZE; j++)
- internals->reta_conf[i].reta[j] = j % dev->data->nb_rx_queues;
+ internals->reta_conf[i].reta[j] =
+ (i * RTE_RETA_GROUP_SIZE + j) %
+ dev->data->nb_rx_queues;
}
}
--
2.18.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2018-09-25 13:26:56.906789299 +0100
+++ 0006-net-bonding-use-evenly-distributed-default-RSS-RETA.patch 2018-09-25 13:26:56.779424704 +0100
@@ -1,8 +1,10 @@
-From 617d1ac2fd22e9a82d305c0607853f4ee0f7277b Mon Sep 17 00:00:00 2001
+From 79e22e7318fa1f79655765796140261dcfaefa55 Mon Sep 17 00:00:00 2001
From: Igor Romanov <igor.romanov@oktetlabs.ru>
Date: Wed, 29 Aug 2018 08:48:30 +0100
Subject: [PATCH] net/bonding: use evenly distributed default RSS RETA
+[ upstream commit 617d1ac2fd22e9a82d305c0607853f4ee0f7277b ]
+
Default Redirection Table that is set in bonding driver is distributed
evenly over all Rx queues only within every RETA group (the first RETA
entries in every group are always start with zero). But in the most
@@ -14,7 +16,6 @@
considering the whole table.
Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
-Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
@@ -24,10 +25,10 @@
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
-index b84f322630..0f5ab09e38 100644
+index 60f9e1ab11..1fe0c179a1 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
-@@ -3293,7 +3293,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
+@@ -2381,7 +2381,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
for (i = 0; i < RTE_DIM(internals->reta_conf); i++) {
internals->reta_conf[i].mask = ~0LL;
for (j = 0; j < RTE_RETA_GROUP_SIZE; j++)