From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id B2BFF2B91 for ; Mon, 29 Oct 2018 13:53:52 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id r10-v6so8558431wrv.6 for ; Mon, 29 Oct 2018 05:53:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AT6w/b38gajZqrZD9VXvcPe5fTvuN7Bdpxpeu29G3g0=; b=YUIHv9U1pf4jGoZ3oUZAc5VPxgC+QLl4slB6smpOzgEYtFSZCfXW7YM7a8HhLzLHP+ fsS/xMz413ZjRplaB7v7fCZVBceKi//ra9JHtYshz6GapuU9aZkNFaSMmHJUnqeuGBhI IUrkLIAdL3zwCPLIH7ADtPoVwMGo+G6Nkj2sK9xF+UaqAyMo1OX+TKqyJpae8nu7RaFG IpWlUVeN1/n8KkFsH4c2lVsZRyCtqjeriErlAeEWTOIrGGlhGFURSphzWBNW/d8Tm+kn N0rD8Ug2n40N2T/JLTDcCwhmVn3OTCYur5vOF6H+EqV/ZUCm49G3AcMjKIzsqvrzcK0u Zx+w== X-Gm-Message-State: AGRZ1gJjwKlt3E3feLrPZRXgCiJniBM1O4uDRy8CqSvzQO29EvFHUrkZ ZjFny279l7jwWC5yUiK5Py9FHmvN X-Google-Smtp-Source: AJdET5e1z5UT7hh1kfDsBbQkzFkRanVV+S/k3PFB05KwLvSVftu84mbtVwF1O7c9H6fygXvgUNWZig== X-Received: by 2002:adf:9501:: with SMTP id 1-v6mr14808433wrs.291.1540817632250; Mon, 29 Oct 2018 05:53:52 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 11-v6sm12740487wmw.31.2018.10.29.05.53.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 05:53:51 -0700 (PDT) From: Luca Boccassi To: Yipeng Wang Cc: Bruce Richardson , Honnappa Nagarahalli , dpdk stable Date: Mon, 29 Oct 2018 12:53:14 +0000 Message-Id: <20181029125329.17729-5-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181029125329.17729-1-bluca@debian.org> References: <20181015115144.27626-1-bluca@debian.org> <20181029125329.17729-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/hash: fix bucket size in perf test' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 12:53:52 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/31/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 84a8bcf5118a58ab7b8c3c5912d13f3b650ae4cc Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 28 Sep 2018 07:11:05 -0700 Subject: [PATCH] test/hash: fix bucket size in perf test [ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ] The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket size set to 4, it mismatches the underneath rte_hash structure, which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- app/test/test_hash_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index c0051b20f..b0514b104 100644 --- a/app/test/test_hash_perf.c +++ b/app/test/test_hash_perf.c @@ -49,7 +49,8 @@ #define MAX_ENTRIES (1 << 19) #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */ -#define BUCKET_SIZE 4 +/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */ +#define BUCKET_SIZE 8 #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) #define MAX_KEYSIZE 64 #define NUM_KEYSIZES 10 -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-10-29 12:48:14.568269644 +0000 +++ 0005-test-hash-fix-bucket-size-in-perf-test.patch 2018-10-29 12:48:14.434417982 +0000 @@ -1,8 +1,10 @@ -From b772a15eb84ce616114880a20ad6ad91bb8970fc Mon Sep 17 00:00:00 2001 +From 84a8bcf5118a58ab7b8c3c5912d13f3b650ae4cc Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 28 Sep 2018 07:11:05 -0700 Subject: [PATCH] test/hash: fix bucket size in perf test +[ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ] + The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. @@ -16,20 +18,19 @@ which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") -Cc: stable@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- - test/test/test_hash_perf.c | 3 ++- + app/test/test_hash_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c -index 33dcb9fcf..fe116326d 100644 ---- a/test/test/test_hash_perf.c -+++ b/test/test/test_hash_perf.c -@@ -20,7 +20,8 @@ +diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c +index c0051b20f..b0514b104 100644 +--- a/app/test/test_hash_perf.c ++++ b/app/test/test_hash_perf.c +@@ -49,7 +49,8 @@ #define MAX_ENTRIES (1 << 19) #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */