From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by dpdk.org (Postfix) with ESMTP id 8C91328FD for ; Thu, 8 Nov 2018 19:01:27 +0100 (CET) Received: by mail-wr1-f51.google.com with SMTP id z16-v6so22248124wrv.2 for ; Thu, 08 Nov 2018 10:01:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VcgrhfqKpRl/K6fd+8jc0aAOrtsJgj9hbTDkgre2zgg=; b=ocAHwzUo778QVFVOWZCeYsarLF+saqhTTf3Bpts3h/s6A+NN2LfOxQgHdLIrZehob5 nFiBpD0dx9qb/CQ9sFh5cuYnOfUQVntMzd/Ig1K3jAEs4dwur2zOWguvZSPZkUXNhJMj xJmj5VituTxnSxy9zmxv5w7MQ0DN7g/wcdx2rFSj7atNgwWGva9cl31xSEVrmlFw63Pi L3mUomJzT8Ifn47nxU9uyRWZwq0/gCX7rQa7anGMl2hAlJhYE3jk30fS1/f+SZCY5ECG mVqHV4FRI5kCBS009pJ9qVD5ah+m8aTSiF8Vnkl0oy8Rv7CNHd1Zf4DExHnbHj8zoy/f KyxQ== X-Gm-Message-State: AGRZ1gLqU/B+heJ7pzjJH377VHtEB3/Qtjh/LbwK8C7P8OZaYLcN1PuC BFFefru8XqfG0K6wI3S5Qdk= X-Google-Smtp-Source: AJdET5eLC/zEDu3Q25VAb8Z7Kf+8vuw9uTh6Nk0qN9CT9AfgFcNXR/Atix25Jg8JfJw3Xv4Zhzy7CA== X-Received: by 2002:adf:91c3:: with SMTP id 61-v6mr5146844wri.97.1541700087112; Thu, 08 Nov 2018 10:01:27 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id r72-v6sm6994988wmb.37.2018.11.08.10.01.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 10:01:26 -0800 (PST) From: Luca Boccassi To: Yongseok Koh Cc: dpdk stable Date: Thu, 8 Nov 2018 18:00:59 +0000 Message-Id: <20181108180111.25873-3-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108180111.25873-1-bluca@debian.org> References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mk: disable gcc AVX512F support' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 18:01:27 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 8dbda3ba255c6045ffe3eb73f1d8e1f67186c22b Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Sat, 3 Nov 2018 01:06:32 +0000 Subject: [PATCH] mk: disable gcc AVX512F support [ upstream commit 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 ] This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. This disables AVX512F support of gcc by adding -mno-avx512f if it is disabled in DPDK (CONFIG_RTE_ENABLE_AVX512=n). This does not apply to the meson build as that doesn't have such an option but always enable AVX512F whenever supported. Bugzilla ID: 97 Signed-off-by: Yongseok Koh --- mk/rte.cpuflags.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 8bbccb9ed..c7027a0fe 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -91,6 +91,11 @@ endif ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) CPUFLAGS += AVX512F +else +# disable AVX512F support of gcc as a workaround for Bug 97 +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) +MACHINE_CFLAGS += -mno-avx512f +endif endif # IBM Power CPU flags -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-08 17:59:30.124667578 +0000 +++ 0003-mk-disable-gcc-AVX512F-support.patch 2018-11-08 17:59:30.048751011 +0000 @@ -1,8 +1,10 @@ -From 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 Mon Sep 17 00:00:00 2001 +From 8dbda3ba255c6045ffe3eb73f1d8e1f67186c22b Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Sat, 3 Nov 2018 01:06:32 +0000 Subject: [PATCH] mk: disable gcc AVX512F support +[ upstream commit 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 ] + This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. @@ -13,7 +15,6 @@ but always enable AVX512F whenever supported. Bugzilla ID: 97 -Cc: stable@dpdk.org Signed-off-by: Yongseok Koh --- @@ -21,12 +22,12 @@ 1 file changed, 5 insertions(+) diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk -index 43ed84155..c3291b17a 100644 +index 8bbccb9ed..c7027a0fe 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk -@@ -68,6 +68,11 @@ endif +@@ -91,6 +91,11 @@ endif + ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) - ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) CPUFLAGS += AVX512F +else +# disable AVX512F support of gcc as a workaround for Bug 97 @@ -34,8 +35,8 @@ +MACHINE_CFLAGS += -mno-avx512f +endif endif - endif + # IBM Power CPU flags -- 2.19.1