From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id BCE734C80 for ; Thu, 8 Nov 2018 19:01:29 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id 74-v6so22209416wrb.13 for ; Thu, 08 Nov 2018 10:01:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WjKpBqZm0693xG6Vl3vWHnfLTHLSk7n+esD9+A4q/KI=; b=U7fr3V4ihPLQ4+7Hautb/LeUxHj+Ac2lf9QVHkr2jy+IJr54YQRljAVjtuJrXaAX6b WUjSjEsFkLO6vYq/HLopbDWwLZreFMDn4aDrkLEgvFMU/18qZZ0tcLGqMobKlllkpMSu 34un1KR2b7ZT1OAi2swZZaK7E9+N5nLh8UH5swWQYXy+jyiK87yD6xf4JUWOiKiHlDxo YNYmwdTE66AcLIfAPBTHzObxK4UnXK42JI/J54X2ozTSHzBRPHA1pe5s/09qru/WYiN2 EA6VnVATg0OYgygq2xIl+AW8xAoHvmP1ao5SHzoHHE7vfUo390jwMYwJvj2ZYFeVym33 Iorg== X-Gm-Message-State: AGRZ1gJFoKm/+4ymfqG/ohs+FOpKCCcUjrKSCY1nTyO0uwXFYb7qoTk8 LGon+RCNXyA7THB5gTB40VQnj3m7 X-Google-Smtp-Source: AJdET5e3Gjq/6R7th6BmsBmU+1PzM1gLsgq0NS3ivmWwBB/9bEhllvOATKN4tYKWkb4fSw6Ita4v6g== X-Received: by 2002:a5d:488a:: with SMTP id g10-v6mr5200718wrq.0.1541700089330; Thu, 08 Nov 2018 10:01:29 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id o15-v6sm4899968wrw.47.2018.11.08.10.01.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 10:01:28 -0800 (PST) From: Luca Boccassi To: Ferruh Yigit Cc: dpdk stable Date: Thu, 8 Nov 2018 18:01:00 +0000 Message-Id: <20181108180111.25873-4-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181108180111.25873-1-bluca@debian.org> References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal: fix build with gcc 9.0' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 18:01:29 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 4bef71f921bc177eb53b4c19c75dc368a1ccb33c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 2 Nov 2018 19:06:06 +0000 Subject: [PATCH] eal: fix build with gcc 9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 3370975b994d793a89812031d86534916067dd67 ] build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: error: ‘strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Werror=stringop-truncation] strncpy(solib->name, path, PATH_MAX-1); strncpy may result a not null-terminated string, replaced it with strlcpy Fixes: f9a08f650211 ("eal: add support for shared object drivers") Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 6ca8af17e..2dc86509b 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -179,7 +179,7 @@ eal_plugin_add(const char *path) return -1; } memset(solib, 0, sizeof(*solib)); - strncpy(solib->name, path, PATH_MAX-1); + strlcpy(solib->name, path, PATH_MAX-1); solib->name[PATH_MAX-1] = 0; TAILQ_INSERT_TAIL(&solib_list, solib, next); -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-08 17:59:30.141904587 +0000 +++ 0004-eal-fix-build-with-gcc-9.0.patch 2018-11-08 17:59:30.048751011 +0000 @@ -1,4 +1,4 @@ -From 3370975b994d793a89812031d86534916067dd67 Mon Sep 17 00:00:00 2001 +From 4bef71f921bc177eb53b4c19c75dc368a1ccb33c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 2 Nov 2018 19:06:06 +0000 Subject: [PATCH] eal: fix build with gcc 9.0 @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 3370975b994d793a89812031d86534916067dd67 ] + build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: @@ -17,7 +19,6 @@ replaced it with strlcpy Fixes: f9a08f650211 ("eal: add support for shared object drivers") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- @@ -25,10 +26,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c -index b82f3ddd1..e31eca5c0 100644 +index 6ca8af17e..2dc86509b 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c -@@ -222,7 +222,7 @@ eal_plugin_add(const char *path) +@@ -179,7 +179,7 @@ eal_plugin_add(const char *path) return -1; } memset(solib, 0, sizeof(*solib));