From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 08A214C92 for ; Fri, 9 Nov 2018 15:26:22 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id p2-v6so2102842wmc.2 for ; Fri, 09 Nov 2018 06:26:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KObgWqe+wGLcZ9CL7tkOXrHSQDAexO45XjN1KgwxjPU=; b=qXVSO1UwgAuyJnDy+mlkU8HzitKKw6bGlYUfeG3dUxfe063d1hcwy23ZEaGVA0Pw82 rMrCoiB4j851BcoBvh/V6Re0txK+TPrdoTADfiuPd9V0SGJXfx+Tnz1+a+Sns4aDFl5I FEJBKP5JeDnOtqGOaEmGokFL3O/YU5LU7rTKn0PvZsyc0qo64+rQBiDMzKsGLu+QRPbD 7Q7g8KwS/kOa00W5H1GtVHcq6Sk443XDQqlTLBSH8NwAmCCYetMtLF+bAqd/PKgzgWci UIx0Z10EjMo869trEiSdRez2IXHNLvMtn/CDboYcDEEXfty6wvMT4JsONIEyORHj7mzO jNhA== X-Gm-Message-State: AGRZ1gLEG5JqgxuSH/5KnTNCEFMOMiLbA+YOpXsUxDJG4zqb2CREqwKp 5X/wcS1ssiZ6vhHkw1gzmhY= X-Google-Smtp-Source: AJdET5cJgjP00oPyJyOCs2RYleLnARIiDWog7/2Gi1hwCbUs89tlCvOuj8SomxIzj1xupRf4bqNrOQ== X-Received: by 2002:a1c:2093:: with SMTP id g141-v6mr4820035wmg.7.1541773581442; Fri, 09 Nov 2018 06:26:21 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id y2-v6sm13237392wrh.53.2018.11.09.06.26.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 06:26:20 -0800 (PST) From: Luca Boccassi To: Ferruh Yigit Cc: Harish Patil , Shijith Thotton , Jingjing Wu , dpdk stable Date: Fri, 9 Nov 2018 14:26:10 +0000 Message-Id: <20181109142611.20254-1-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <1541700985.31208.25.camel@debian.org> References: <1541700985.31208.25.camel@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'igb_uio: remove device reset in open' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 14:26:22 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/11/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 278a18a19d7f15aba9c291c6fa7c27e307df976a Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 20 Oct 2017 17:55:11 +0100 Subject: [PATCH] igb_uio: remove device reset in open [ upstream commit f73b38e9245d77d4d6b5861f8d203c0bf5120b15 ] Remove device reset during application start, the reset for application exit still there. Reset in open removed because of following comments: 1- Device reset not completed when VF driver loaded, which cause VF PMD initialization error. Adding delay can solve the issue but will increase driver load time. 2- Reset will be issues all devices unconditionally, not very efficient way. Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") Signed-off-by: Ferruh Yigit Tested-by: Harish Patil Tested-by: Shijith Thotton Tested-by: Jingjing Wu --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 4be89ef86..bedfa6eae 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -179,8 +179,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode) struct rte_uio_pci_dev *udev = info->priv; struct pci_dev *dev = udev->pdev; - pci_reset_function(dev); - /* set bus master, which was cleared by the reset function */ pci_set_master(dev); -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-09 14:24:58.312257299 +0000 +++ 0002-igb_uio-remove-device-reset-in-open.patch 2018-11-09 14:24:58.269726115 +0000 @@ -1,8 +1,10 @@ -From f73b38e9245d77d4d6b5861f8d203c0bf5120b15 Mon Sep 17 00:00:00 2001 +From 278a18a19d7f15aba9c291c6fa7c27e307df976a Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 20 Oct 2017 17:55:11 +0100 Subject: [PATCH] igb_uio: remove device reset in open +[ upstream commit f73b38e9245d77d4d6b5861f8d203c0bf5120b15 ] + Remove device reset during application start, the reset for application exit still there. @@ -15,7 +17,6 @@ way. Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Tested-by: Harish Patil @@ -26,12 +27,12 @@ 1 file changed, 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c -index f7ef82554..fd320d87d 100644 +index 4be89ef86..bedfa6eae 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c -@@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode) +@@ -179,8 +179,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode) + struct rte_uio_pci_dev *udev = info->priv; struct pci_dev *dev = udev->pdev; - int err; - pci_reset_function(dev); -