From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by dpdk.org (Postfix) with ESMTP id CBFCA4F9A for ; Mon, 19 Nov 2018 13:25:57 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id 125so3102989wmh.0 for ; Mon, 19 Nov 2018 04:25:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cHpoeQKhivANHBFiqcbbrs8p90J21xpnPNeEXrqLYKU=; b=ZTVnqAIllmDZlKFnoYhz2y8X1xvhvFVbR8WJVxgxiITfLPCxT/hr6eqMgK8Y32OMB0 MAWsEShLxMQ2bkhpE+kxF2Lm2tiFv7sJpzbdsD9/skqu3dV5eD7fR4YwTAfAB9JMl4Za n951gTzLmkexV0w8EiH+osNdKbXxpKc8wEWO7BWTLJQ17wzXCR5hcI0r60NjfAryVh32 AGrIo6jwOOc8RjFkp0jOUpI2kHETIn9yWfjLjH3kEbYnrB0h+0+CAJzgi6wfrv5BtnC9 jcgRAlwVo3qifDADeiNYLjBYk3G+RJYvoZxtT0RbIcz5nuNWJdJ1d9g1lNNO2xxg+uUV r2HQ== X-Gm-Message-State: AGRZ1gLMhCQbrSAPXg3N8/RqkGK0xyFrL/sy7ulp3Deq84b6mAMc9jbn AYoBZUKJj1LKtwhH99ouD04= X-Google-Smtp-Source: AJdET5c9Kep7bZm/QfoeGLYbuYnCwBLQNX+2VQZP2j6CRwbGsgt0kgCcQz9V7xiGATVDz8QEFqr7Gw== X-Received: by 2002:a1c:8095:: with SMTP id b143mr6720487wmd.63.1542630357407; Mon, 19 Nov 2018 04:25:57 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 6sm3160399wmk.26.2018.11.19.04.25.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 04:25:56 -0800 (PST) From: Luca Boccassi To: Tiwei Bie Cc: Maxime Coquelin , dpdk stable Date: Mon, 19 Nov 2018 12:25:26 +0000 Message-Id: <20181119122538.14207-9-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119122538.14207-1-bluca@debian.org> References: <20181108180111.25873-1-bluca@debian.org> <20181119122538.14207-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'vhost: remove unneeded null pointer check' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 12:25:57 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 39788a8c71b103ec010838f7605e9fb1f7807bb5 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Wed, 7 Nov 2018 17:01:02 +0800 Subject: [PATCH] vhost: remove unneeded null pointer check [ upstream commit 0541588a44bff07e4aae4c9cde8586326955c378 ] The caller will guarantee that msg won't be null. Remove the unneeded null pointer check which caused a Coverity warning. Coverity issue: 323484 Fixes: 8f972312b8f4 ("vhost: support vhost-user") Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 814bafd73..00872c868 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -956,7 +956,7 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg) if (ret <= 0) return ret; - if (msg && msg->size) { + if (msg->size) { if (msg->size > sizeof(msg->payload)) { RTE_LOG(ERR, VHOST_CONFIG, "invalid msg size: %d\n", msg->size); -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-19 12:15:18.293676210 +0000 +++ 0009-vhost-remove-unneeded-null-pointer-check.patch 2018-11-19 12:15:18.079611433 +0000 @@ -1,15 +1,16 @@ -From 0541588a44bff07e4aae4c9cde8586326955c378 Mon Sep 17 00:00:00 2001 +From 39788a8c71b103ec010838f7605e9fb1f7807bb5 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Wed, 7 Nov 2018 17:01:02 +0800 Subject: [PATCH] vhost: remove unneeded null pointer check +[ upstream commit 0541588a44bff07e4aae4c9cde8586326955c378 ] + The caller will guarantee that msg won't be null. Remove the unneeded null pointer check which caused a Coverity warning. Coverity issue: 323484 Fixes: 8f972312b8f4 ("vhost: support vhost-user") -Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c -index cc154f312..3ea64eba6 100644 +index 814bafd73..00872c868 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c -@@ -1732,7 +1732,7 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg) +@@ -956,7 +956,7 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg) if (ret <= 0) return ret;