From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3A7972BD5 for ; Mon, 19 Nov 2018 13:50:10 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 04:50:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,252,1539673200"; d="scan'208";a="101437286" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.173]) by orsmga003.jf.intel.com with ESMTP; 19 Nov 2018 04:50:08 -0800 Date: Mon, 19 Nov 2018 20:48:25 +0800 From: Tiwei Bie To: Luca Boccassi Cc: Maxime Coquelin , dpdk stable Message-ID: <20181119124825.GA6155@debian> References: <20181108180111.25873-1-bluca@debian.org> <20181119122538.14207-1-bluca@debian.org> <20181119122538.14207-8-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181119122538.14207-8-bluca@debian.org> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-stable] patch 'net/virtio: fix unchecked return value' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 12:50:10 -0000 On Mon, Nov 19, 2018 at 12:25:25PM +0000, Luca Boccassi wrote: > Hi, > > FYI, your patch has been queued to LTS release 16.11.9 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 11/21/18. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the patch applied > to the branch. If the code is different (ie: not only metadata diffs), due for example to > a change in context or macro names, please double check it. > > Thanks. > > Luca Boccassi > > --- > From 87b9d321789f9bdaa2cf11df2f7377bc1145e7fa Mon Sep 17 00:00:00 2001 > From: Tiwei Bie > Date: Wed, 7 Nov 2018 17:01:01 +0800 > Subject: [PATCH] net/virtio: fix unchecked return value > > [ upstream commit ecfae1510edc1391285aa566a2d31e7eae8fc6d2 ] > > Coverity issue: 302861 > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") > > Signed-off-by: Tiwei Bie > Reviewed-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_pci.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > index f6d697f38..13ad57dfd 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -690,9 +690,15 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw) > hw->common_cfg = get_cfg_addr(dev, &cap); > break; > case VIRTIO_PCI_CAP_NOTIFY_CFG: > - rte_eal_pci_read_config(dev, &hw->notify_off_multiplier, > - 4, pos + sizeof(cap)); > - hw->notify_base = get_cfg_addr(dev, &cap); > + ret = rte_eal_pci_read_config(dev, > + &hw->notify_off_multiplier, > + 4, pos + sizeof(cap)); > + if (ret != 4) Hi Luca, This patch can't be backported, because it depends on an API change in newer release. Thanks > + PMD_INIT_LOG(DEBUG, > + "failed to read notify_off_multiplier, ret %d", > + ret); > + else > + hw->notify_base = get_cfg_addr(dev, &cap); > break; > case VIRTIO_PCI_CAP_DEVICE_CFG: > hw->dev_cfg = get_cfg_addr(dev, &cap); > -- > 2.19.1 [...]