From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3C2261B10D for ; Wed, 21 Nov 2018 17:50:04 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90D2C30833A6; Wed, 21 Nov 2018 16:50:03 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 796975C22E; Wed, 21 Nov 2018 16:50:02 +0000 (UTC) From: Kevin Traynor To: Matthew Smith Cc: Qi Zhang , dpdk stable Date: Wed, 21 Nov 2018 16:47:36 +0000 Message-Id: <20181121164828.32249-22-ktraynor@redhat.com> In-Reply-To: <20181121164828.32249-1-ktraynor@redhat.com> References: <20181121164828.32249-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 21 Nov 2018 16:50:03 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ixgbe: wait longer for link after fiber MAC setup' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:50:04 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 80d65af2b201190e2265e084a28700b5a05c8f11 Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Mon, 16 Jul 2018 11:36:04 -0500 Subject: [PATCH] net/ixgbe: wait longer for link after fiber MAC setup [ upstream commit 64f1c8539c8ce99214b9eb1fb728a2c6745f3300 ] After setting up the link on a fiber port, the maximum wait time for the link to come up is 500 ms in ixgbe_setup_mac_link_multispeed_fiber(). On an x550 SFP+ port, this is often not sufficiently long for the link to come up. This can result in never being able to retrieve accurate link status for the port using rte_eth_link_get_nowait(). Increase the maximum wait time in ixgbe_setup_mac_link_multispeed_fiber() to 1 s. Bugzilla ID: 69 Fixes: f3430431abaf ("ixgbe/base: add SFP+ dual-speed support") Signed-off-by: Matthew Smith Acked-by: Qi Zhang --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index e7e9256e5..2fb0a072c 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -5297,5 +5297,5 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw, * attempted. 82599 uses the same timing for 10g SFI. */ - for (i = 0; i < 5; i++) { + for (i = 0; i < 10; i++) { /* Wait for the link partner to also set speed */ msec_delay(100); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 16:44:31.531790630 +0000 +++ 0022-net-ixgbe-wait-longer-for-link-after-fiber-MAC-setup.patch 2018-11-21 16:44:30.000000000 +0000 @@ -1,8 +1,10 @@ -From 64f1c8539c8ce99214b9eb1fb728a2c6745f3300 Mon Sep 17 00:00:00 2001 +From 80d65af2b201190e2265e084a28700b5a05c8f11 Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Mon, 16 Jul 2018 11:36:04 -0500 Subject: [PATCH] net/ixgbe: wait longer for link after fiber MAC setup +[ upstream commit 64f1c8539c8ce99214b9eb1fb728a2c6745f3300 ] + After setting up the link on a fiber port, the maximum wait time for the link to come up is 500 ms in ixgbe_setup_mac_link_multispeed_fiber(). On an x550 SFP+ port, this is often not sufficiently long for the link @@ -14,7 +16,6 @@ Bugzilla ID: 69 Fixes: f3430431abaf ("ixgbe/base: add SFP+ dual-speed support") -Cc: stable@dpdk.org Signed-off-by: Matthew Smith Acked-by: Qi Zhang @@ -23,10 +24,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c -index b4a0d7003..21f973e5e 100644 +index e7e9256e5..2fb0a072c 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c -@@ -5263,5 +5263,5 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw, +@@ -5297,5 +5297,5 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw, * attempted. 82599 uses the same timing for 10g SFI. */ - for (i = 0; i < 5; i++) {