From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7E05F1B108 for ; Wed, 21 Nov 2018 17:51:08 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D9BD23164687; Wed, 21 Nov 2018 16:51:07 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8CBA5C21E; Wed, 21 Nov 2018 16:51:06 +0000 (UTC) From: Kevin Traynor To: Ivan Malov Cc: Andrew Rybchenko , dpdk stable Date: Wed, 21 Nov 2018 16:48:21 +0000 Message-Id: <20181121164828.32249-67-ktraynor@redhat.com> In-Reply-To: <20181121164828.32249-1-ktraynor@redhat.com> References: <20181121164828.32249-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 21 Nov 2018 16:51:07 +0000 (UTC) Subject: [dpdk-stable] patch 'net/sfc: allow to query RSS key and HF when RSS is disabled' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:51:09 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From fcd376d4082e9b0cd1d070029e0061e8f2844caa Mon Sep 17 00:00:00 2001 From: Ivan Malov Date: Thu, 11 Oct 2018 15:51:13 +0100 Subject: [PATCH] net/sfc: allow to query RSS key and HF when RSS is disabled [ upstream commit 662e382244fb29d8bf03113524a139541e10123f ] If global RSS is not enabled in the multiqueue mode setting, it will not be possible to change RSS configuration. However, querying default RSS settings should be possible in any case since it may be needed by RTE flow API users to find out what RSS settings will be used by default for a flow rule with RSS action if custom RSS key and hash function choice are not specified. Fixes: 63ab5e0c8fda ("net/sfc: use zero RSS channels as disabled RSS indicator") Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index d38a3f4e8..f972d2b82 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1348,7 +1348,4 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, return -ENOTSUP; - if (rss->channels == 0) - return -EINVAL; - sfc_adapter_lock(sa); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 16:44:32.767448721 +0000 +++ 0067-net-sfc-allow-to-query-RSS-key-and-HF-when-RSS-is-di.patch 2018-11-21 16:44:30.000000000 +0000 @@ -1,8 +1,10 @@ -From 662e382244fb29d8bf03113524a139541e10123f Mon Sep 17 00:00:00 2001 +From fcd376d4082e9b0cd1d070029e0061e8f2844caa Mon Sep 17 00:00:00 2001 From: Ivan Malov Date: Thu, 11 Oct 2018 15:51:13 +0100 Subject: [PATCH] net/sfc: allow to query RSS key and HF when RSS is disabled +[ upstream commit 662e382244fb29d8bf03113524a139541e10123f ] + If global RSS is not enabled in the multiqueue mode setting, it will not be possible to change RSS configuration. However, querying default RSS settings should be possible in any case since @@ -11,7 +13,6 @@ RSS key and hash function choice are not specified. Fixes: 63ab5e0c8fda ("net/sfc: use zero RSS channels as disabled RSS indicator") -Cc: stable@dpdk.org Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko @@ -20,10 +21,10 @@ 1 file changed, 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c -index 00f088013..b2e17f26e 100644 +index d38a3f4e8..f972d2b82 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c -@@ -1359,7 +1359,4 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, +@@ -1348,7 +1348,4 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, return -ENOTSUP; - if (rss->channels == 0)