From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by dpdk.org (Postfix) with ESMTP id ACD561B615 for ; Mon, 26 Nov 2018 13:49:24 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id v13so15310633wrw.5 for ; Mon, 26 Nov 2018 04:49:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eYymyFpzfJnF+Ud00jZDlMIsC5EYiFipDOTZ19P+S5o=; b=iqSq+fneg0XuzsdW3FGTKysgTr9ijJsaVnV3QFJo1sRWH3941JxZ6w5zM3fAFoy3f7 g0MBCffzr2nzpShXVND/8Tm85oqVYZsmvDE4gksqYux5TaurnVQGBb+uf5/CcW0k5Mwz g5NX8uQIaVZtM6Uw0v8/RZMQsvOLY0DlRx/cJgVR3/PfMooZqvcVJrzwH+wV4zROKt5O 71tU2sI5W2aRJpIGsi+y4H+GKhXN9UJXaeu1kJYJW7pcQKZjMAGR09mXkXSpD8yUmsNa /+J1uT9oTqNbDvQNfK4cHeQQk8s0n0PJqUozPbUezGe/q0gvfC1ik4FqYIUrRyrULAKU 35pw== X-Gm-Message-State: AA+aEWaT3Mb/oP5ivMBHi09kC5u83woLFQUXdSaKuPxooR1yedEr//EH FkpWFaoldSxmFK3/naaQxlA= X-Google-Smtp-Source: AFSGD/XBSViMzYFUJQW9hchgWUD8SKRwAwguSJDK1zE3Lo902Hnd0xyFOVQ/g39vtZL6kuANpX3C6w== X-Received: by 2002:adf:e54a:: with SMTP id z10mr22951831wrm.238.1543236564295; Mon, 26 Nov 2018 04:49:24 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id d5sm129279wrx.22.2018.11.26.04.49.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 04:49:23 -0800 (PST) From: Luca Boccassi To: Thomas Monjalon Cc: dpdk stable Date: Mon, 26 Nov 2018 12:49:13 +0000 Message-Id: <20181126124916.16240-2-bluca@debian.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181126124916.16240-1-bluca@debian.org> References: <20181119122538.14207-1-bluca@debian.org> <20181126124916.16240-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'kni: fix possible uninitialized variable' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 12:49:24 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From f81caeb00aafc05e15ecd2178987bc9deafd5fe4 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 16 Nov 2018 17:58:51 +0100 Subject: [PATCH] kni: fix possible uninitialized variable [ upstream commit a17842c1421c1b26f9deed4f6684abdba06e7a56 ] This error can be raised: lib/librte_kni/rte_kni.c:531:15: error: 'req' may be used uninitialized in this function It should not happen because kni_fifo_get() would return 0 if req is not initialized, so the function would return before using req. But GCC complains about it in -O1 optimization, and a NULL initialization is harmless here. Fixes: 3fc5ca2f6352 ("kni: initial import") Signed-off-by: Thomas Monjalon --- lib/librte_kni/rte_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c index 0c6641bfa..12656a9d4 100644 --- a/lib/librte_kni/rte_kni.c +++ b/lib/librte_kni/rte_kni.c @@ -532,7 +532,7 @@ int rte_kni_handle_request(struct rte_kni *kni) { unsigned ret; - struct rte_kni_request *req; + struct rte_kni_request *req = NULL; if (kni == NULL) return -1; -- 2.19.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-26 12:45:13.650678684 +0000 +++ 0002-kni-fix-possible-uninitialized-variable.patch 2018-11-26 12:45:13.603202331 +0000 @@ -1,8 +1,10 @@ -From a17842c1421c1b26f9deed4f6684abdba06e7a56 Mon Sep 17 00:00:00 2001 +From f81caeb00aafc05e15ecd2178987bc9deafd5fe4 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 16 Nov 2018 17:58:51 +0100 Subject: [PATCH] kni: fix possible uninitialized variable +[ upstream commit a17842c1421c1b26f9deed4f6684abdba06e7a56 ] + This error can be raised: lib/librte_kni/rte_kni.c:531:15: error: 'req' may be used uninitialized in this function @@ -13,7 +15,6 @@ and a NULL initialization is harmless here. Fixes: 3fc5ca2f6352 ("kni: initial import") -Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- @@ -21,10 +22,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c -index c9726d4f8..73aeccccf 100644 +index 0c6641bfa..12656a9d4 100644 --- a/lib/librte_kni/rte_kni.c +++ b/lib/librte_kni/rte_kni.c -@@ -483,7 +483,7 @@ int +@@ -532,7 +532,7 @@ int rte_kni_handle_request(struct rte_kni *kni) { unsigned ret;