From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 528751B4B7 for ; Thu, 29 Nov 2018 14:22:12 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA80F30001DF; Thu, 29 Nov 2018 13:22:11 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 472B71001F50; Thu, 29 Nov 2018 13:22:09 +0000 (UTC) From: Kevin Traynor To: Tiwei Bie Cc: Maxime Coquelin , dpdk stable Date: Thu, 29 Nov 2018 13:20:16 +0000 Message-Id: <20181129132128.7609-16-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 29 Nov 2018 13:22:11 +0000 (UTC) Subject: [dpdk-stable] patch 'vhost: remove unneeded null pointer check' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:22:12 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 148cbf44ba826afe3d7474c8ccfb8df6b534e997 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Wed, 7 Nov 2018 17:01:02 +0800 Subject: [PATCH] vhost: remove unneeded null pointer check [ upstream commit 0541588a44bff07e4aae4c9cde8586326955c378 ] The caller will guarantee that msg won't be null. Remove the unneeded null pointer check which caused a Coverity warning. Coverity issue: 323484 Fixes: 8f972312b8f4 ("vhost: support vhost-user") Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index d19d78ce5..3738ae055 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1425,5 +1425,5 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg) return ret; - if (msg && msg->size) { + if (msg->size) { if (msg->size > sizeof(msg->payload)) { RTE_LOG(ERR, VHOST_CONFIG, -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:35.419233891 +0000 +++ 0015-vhost-remove-unneeded-null-pointer-check.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,15 +1,16 @@ -From 0541588a44bff07e4aae4c9cde8586326955c378 Mon Sep 17 00:00:00 2001 +From 148cbf44ba826afe3d7474c8ccfb8df6b534e997 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Wed, 7 Nov 2018 17:01:02 +0800 Subject: [PATCH] vhost: remove unneeded null pointer check +[ upstream commit 0541588a44bff07e4aae4c9cde8586326955c378 ] + The caller will guarantee that msg won't be null. Remove the unneeded null pointer check which caused a Coverity warning. Coverity issue: 323484 Fixes: 8f972312b8f4 ("vhost: support vhost-user") -Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c -index cc154f312..3ea64eba6 100644 +index d19d78ce5..3738ae055 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c -@@ -1733,5 +1733,5 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg) +@@ -1425,5 +1425,5 @@ read_vhost_message(int sockfd, struct VhostUserMsg *msg) return ret; - if (msg && msg->size) {