From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6A49A1B4AA for ; Thu, 29 Nov 2018 14:22:49 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D0EB430001D7; Thu, 29 Nov 2018 13:22:48 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E9DB1001F50; Thu, 29 Nov 2018 13:22:46 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Ravi Kumar , dpdk stable Date: Thu, 29 Nov 2018 13:20:32 +0000 Message-Id: <20181129132128.7609-32-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 29 Nov 2018 13:22:48 +0000 (UTC) Subject: [dpdk-stable] patch 'crypto/ccp: fix resource leak' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:22:49 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 94b8e8a7c7c9dda9c22c26e3981cb9dcdb2a08c8 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Sun, 28 Oct 2018 03:19:27 +0000 Subject: [PATCH] crypto/ccp: fix resource leak [ upstream commit 5ef2566e0df8b36ae7cd91b6ef6adb4cdc3e7d99 ] File *fp, opened but not closed, this patch add fclose(fp) Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: Ferruh Yigit Reviewed-by: Ravi Kumar --- drivers/crypto/ccp/ccp_pci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp_pci.c b/drivers/crypto/ccp/ccp_pci.c index 59152ca5d..1702a09c4 100644 --- a/drivers/crypto/ccp/ccp_pci.c +++ b/drivers/crypto/ccp/ccp_pci.c @@ -32,10 +32,13 @@ ccp_check_pci_uio_module(void) while (fgets(buf, sizeof(buf), fp) != NULL) { if (!strncmp(buf, uio_module_names[i], - strlen(uio_module_names[i]))) + strlen(uio_module_names[i]))) { + fclose(fp); return i; + } } i++; rewind(fp); } + fclose(fp); printf("Insert igb_uio or uio_pci_generic kernel module(s)"); return -1;/* uio not inserted */ -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:35.843481696 +0000 +++ 0031-crypto-ccp-fix-resource-leak.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,12 +1,13 @@ -From 5ef2566e0df8b36ae7cd91b6ef6adb4cdc3e7d99 Mon Sep 17 00:00:00 2001 +From 94b8e8a7c7c9dda9c22c26e3981cb9dcdb2a08c8 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Sun, 28 Oct 2018 03:19:27 +0000 Subject: [PATCH] crypto/ccp: fix resource leak +[ upstream commit 5ef2566e0df8b36ae7cd91b6ef6adb4cdc3e7d99 ] + File *fp, opened but not closed, this patch add fclose(fp) Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: Ravi Kumar