From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DFC4A1B4B7 for ; Thu, 29 Nov 2018 14:22:57 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52297315485E; Thu, 29 Nov 2018 13:22:57 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C4741001F50; Thu, 29 Nov 2018 13:22:56 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: dpdk stable Date: Thu, 29 Nov 2018 13:20:37 +0000 Message-Id: <20181129132128.7609-37-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 29 Nov 2018 13:22:57 +0000 (UTC) Subject: [dpdk-stable] patch 'test/reorder: fix out of bound access' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:22:58 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 9a46a347c841c4d9fd2de8d53cf88e004744d69f Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 13 Nov 2018 23:31:37 +0000 Subject: [PATCH] test/reorder: fix out of bound access [ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ] The value of array index 'i' is out of bound because of the previous loop it has been used. Assuming intention is using '0' since the check before free is robufs[0] check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") Signed-off-by: Ferruh Yigit --- test/test/test_reorder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_reorder.c b/test/test/test_reorder.c index ccee4d086..58fa9c71b 100644 --- a/test/test/test_reorder.c +++ b/test/test/test_reorder.c @@ -270,5 +270,5 @@ test_reorder_drain(void) } if (robufs[0] != NULL) - rte_pktmbuf_free(robufs[i]); + rte_pktmbuf_free(robufs[0]); /* Insert more packets -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:35.973925344 +0000 +++ 0036-test-reorder-fix-out-of-bound-access.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,8 +1,10 @@ -From 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f Mon Sep 17 00:00:00 2001 +From 9a46a347c841c4d9fd2de8d53cf88e004744d69f Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 13 Nov 2018 23:31:37 +0000 Subject: [PATCH] test/reorder: fix out of bound access +[ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ] + The value of array index 'i' is out of bound because of the previous loop it has been used. @@ -10,7 +12,6 @@ check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit ---