From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3BA5E1B4BA for ; Thu, 29 Nov 2018 14:23:02 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9AC033098482; Thu, 29 Nov 2018 13:23:01 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8AFD1019626; Thu, 29 Nov 2018 13:22:59 +0000 (UTC) From: Kevin Traynor To: Luca Boccassi Cc: Christian Ehrhardt , dpdk stable Date: Thu, 29 Nov 2018 13:20:39 +0000 Message-Id: <20181129132128.7609-39-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 29 Nov 2018 13:23:01 +0000 (UTC) Subject: [dpdk-stable] patch 'build: set -mfpu=neon flag for armv7-a with meson' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:23:02 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From d134dc958af966ddce61f8e66a48500c1ea6e8ad Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Thu, 15 Nov 2018 16:54:18 +0000 Subject: [PATCH] build: set -mfpu=neon flag for armv7-a with meson MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit daf6c3c10e91b1c0dcb872f385116dc4aa477556 ] Building on armv7a with meson currenctly fails: /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error: inlining failed in call to always_inline ‘vld1q_s32’: target specific option mismatch Set -mfpu=neon on that architecture like the legacy makefiles do to fix the issue. Fixes: b1d48c41189a ("build: support ARM with meson") Signed-off-by: Luca Boccassi Acked-by: Christian Ehrhardt --- config/arm/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 94cca490e..b497901b0 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -90,4 +90,7 @@ if cc.sizeof('void *') != 8 dpdk_conf.set('RTE_ARCH_ARM', 1) dpdk_conf.set('RTE_ARCH_ARMv7', 1) + # the minimum architecture supported, armv7-a, needs the following, + # mk/machine/armv7a/rte.vars.mk sets it too + machine_args += '-mfpu=neon' else dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128) -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:36.031376954 +0000 +++ 0038-build-set-mfpu-neon-flag-for-armv7-a-with-meson.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,4 +1,4 @@ -From daf6c3c10e91b1c0dcb872f385116dc4aa477556 Mon Sep 17 00:00:00 2001 +From d134dc958af966ddce61f8e66a48500c1ea6e8ad Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Thu, 15 Nov 2018 16:54:18 +0000 Subject: [PATCH] build: set -mfpu=neon flag for armv7-a with meson @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit daf6c3c10e91b1c0dcb872f385116dc4aa477556 ] + Building on armv7a with meson currenctly fails: /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error: @@ -16,7 +18,6 @@ the issue. Fixes: b1d48c41189a ("build: support ARM with meson") -Cc: stable@dpdk.org Signed-off-by: Luca Boccassi Acked-by: Christian Ehrhardt @@ -25,7 +26,7 @@ 1 file changed, 3 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build -index 4b23b3954..b75513855 100644 +index 94cca490e..b497901b0 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -90,4 +90,7 @@ if cc.sizeof('void *') != 8