From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9AA201B4AA for ; Thu, 29 Nov 2018 14:23:04 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DEA8D308212A; Thu, 29 Nov 2018 13:23:03 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id E83FA1001F50; Thu, 29 Nov 2018 13:23:01 +0000 (UTC) From: Kevin Traynor To: Chaitanya Babu Talluri Cc: Reshma Pattan , Ferruh Yigit , dpdk stable Date: Thu, 29 Nov 2018 13:20:40 +0000 Message-Id: <20181129132128.7609-40-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 29 Nov 2018 13:23:04 +0000 (UTC) Subject: [dpdk-stable] patch 'efd: fix write unlock during ring creation' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:23:04 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From b2fa543c8a21f3464bf62695d5a8bd57cdd62898 Mon Sep 17 00:00:00 2001 From: Chaitanya Babu Talluri Date: Wed, 14 Nov 2018 11:24:06 +0000 Subject: [PATCH] efd: fix write unlock during ring creation [ upstream commit f493119397d0f5dbe33f67697ff09aa646e5f17c ] In rte_efd_create() write lock has already been unlocked before ring creation itself. So second unlock after the ring creation has been removed. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Signed-off-by: Chaitanya Babu Talluri Acked-by: Reshma Pattan Reviewed-by: Ferruh Yigit --- lib/librte_efd/rte_efd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index a780e2fe8..e6e5cfda2 100644 --- a/lib/librte_efd/rte_efd.c +++ b/lib/librte_efd/rte_efd.c @@ -693,5 +693,6 @@ rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, if (r == NULL) { RTE_LOG(ERR, EFD, "memory allocation failed\n"); - goto error_unlock_exit; + rte_efd_free(table); + return NULL; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:36.053239227 +0000 +++ 0039-efd-fix-write-unlock-during-ring-creation.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,14 +1,15 @@ -From f493119397d0f5dbe33f67697ff09aa646e5f17c Mon Sep 17 00:00:00 2001 +From b2fa543c8a21f3464bf62695d5a8bd57cdd62898 Mon Sep 17 00:00:00 2001 From: Chaitanya Babu Talluri Date: Wed, 14 Nov 2018 11:24:06 +0000 Subject: [PATCH] efd: fix write unlock during ring creation +[ upstream commit f493119397d0f5dbe33f67697ff09aa646e5f17c ] + In rte_efd_create() write lock has already been unlocked before ring creation itself. So second unlock after the ring creation has been removed. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") -Cc: stable@dpdk.org Signed-off-by: Chaitanya Babu Talluri Acked-by: Reshma Pattan