From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 07D7D1B4BA for ; Thu, 29 Nov 2018 14:23:37 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6ED5583F3E; Thu, 29 Nov 2018 13:23:36 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B7BD1001F50; Thu, 29 Nov 2018 13:23:34 +0000 (UTC) From: Kevin Traynor To: Jasvinder Singh Cc: dpdk stable Date: Thu, 29 Nov 2018 13:20:56 +0000 Message-Id: <20181129132128.7609-56-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 29 Nov 2018 13:23:36 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: fix memory leak for DSCP table' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:23:37 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From c77be5d82097f4c82dc413ae4c7c7637d1960683 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Wed, 14 Nov 2018 11:58:59 +0000 Subject: [PATCH] app/testpmd: fix memory leak for DSCP table [ upstream commit 5fe5678de9c508332ea37d90a8267c3a2066219e ] Fix memory leak for dscp table reported by coverity Coverity issue: 326961 Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index 846de88db..c506d87ee 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -1149,13 +1149,13 @@ static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result, if (port_id_is_invalid(port_id, ENABLED_WARN)) - return; + goto free_table; /* Update Meter DSCP Table*/ ret = rte_mtr_meter_dscp_table_update(port_id, mtr_id, dscp_table, &error); - if (ret != 0) { + if (ret != 0) print_err_msg(&error); - return; - } + +free_table: free(dscp_table); } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:36.465538824 +0000 +++ 0055-app-testpmd-fix-memory-leak-for-DSCP-table.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,13 +1,14 @@ -From 5fe5678de9c508332ea37d90a8267c3a2066219e Mon Sep 17 00:00:00 2001 +From c77be5d82097f4c82dc413ae4c7c7637d1960683 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Wed, 14 Nov 2018 11:58:59 +0000 Subject: [PATCH] app/testpmd: fix memory leak for DSCP table +[ upstream commit 5fe5678de9c508332ea37d90a8267c3a2066219e ] + Fix memory leak for dscp table reported by coverity Coverity issue: 326961 Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") -Cc: stable@dpdk.org Signed-off-by: Jasvinder Singh ---