From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6FD921B4AA for ; Thu, 29 Nov 2018 14:23:46 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D39923DBEC; Thu, 29 Nov 2018 13:23:45 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9A069105705E; Thu, 29 Nov 2018 13:23:44 +0000 (UTC) From: Kevin Traynor To: Phil Yang Cc: Gavin Hu , dpdk stable Date: Thu, 29 Nov 2018 13:21:01 +0000 Message-Id: <20181129132128.7609-61-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 29 Nov 2018 13:23:45 +0000 (UTC) Subject: [dpdk-stable] patch 'test: release ring resources after PMD perf test' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:23:46 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From c8ce9b37ad4eafcc0d3ec4a8ad89268dcee7554a Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Fri, 19 Oct 2018 19:00:38 +0800 Subject: [PATCH] test: release ring resources after PMD perf test [ upstream commit bc44d448479846966f7aedb90fefe2fa5bd20d2e ] Need to release the port and the ring resources after test. Otherwise, it will cause failure to allocate memory when reentry the test. Fixes: ea764af ("app/test: add performance test for ring driver") Signed-off-by: Phil Yang Reviewed-by: Gavin Hu --- test/test/test_pmd_ring_perf.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/test/test_pmd_ring_perf.c b/test/test/test_pmd_ring_perf.c index ad5004a69..6318da18f 100644 --- a/test/test/test_pmd_ring_perf.c +++ b/test/test/test_pmd_ring_perf.c @@ -11,4 +11,5 @@ #include #include +#include #include "test.h" @@ -136,4 +137,6 @@ static int test_ring_pmd_perf(void) { + char name[RTE_ETH_NAME_MAX_LEN]; + r = rte_ring_create(RING_NAME, RING_SIZE, rte_socket_id(), RING_F_SP_ENQ|RING_F_SC_DEQ); @@ -152,4 +155,9 @@ test_ring_pmd_perf(void) test_bulk_enqueue_dequeue(); + /* release port and ring resources */ + rte_eth_dev_stop(ring_ethdev_port); + rte_eth_dev_get_name_by_port(ring_ethdev_port, name); + rte_vdev_uninit(name); + rte_ring_free(r); return 0; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:36.580048591 +0000 +++ 0060-test-release-ring-resources-after-PMD-perf-test.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,13 +1,14 @@ -From bc44d448479846966f7aedb90fefe2fa5bd20d2e Mon Sep 17 00:00:00 2001 +From c8ce9b37ad4eafcc0d3ec4a8ad89268dcee7554a Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Fri, 19 Oct 2018 19:00:38 +0800 Subject: [PATCH] test: release ring resources after PMD perf test +[ upstream commit bc44d448479846966f7aedb90fefe2fa5bd20d2e ] + Need to release the port and the ring resources after test. Otherwise, it will cause failure to allocate memory when reentry the test. Fixes: ea764af ("app/test: add performance test for ring driver") -Cc: stable@dpdk.org Signed-off-by: Phil Yang Reviewed-by: Gavin Hu