From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5C8A21B4B6 for ; Thu, 29 Nov 2018 14:24:08 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C4C5E3001563; Thu, 29 Nov 2018 13:24:07 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F11A1001F50; Thu, 29 Nov 2018 13:24:06 +0000 (UTC) From: Kevin Traynor To: Nikhil Rao Cc: Jerin Jacob , dpdk stable Date: Thu, 29 Nov 2018 13:21:13 +0000 Message-Id: <20181129132128.7609-73-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 29 Nov 2018 13:24:07 +0000 (UTC) Subject: [dpdk-stable] patch 'eventdev: fix unlock in Rx adapter' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:24:08 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 51c4f7b40b7532c02a398fa19d5dfb183cd2e9fb Mon Sep 17 00:00:00 2001 From: Nikhil Rao Date: Wed, 21 Nov 2018 03:39:15 +0530 Subject: [PATCH] eventdev: fix unlock in Rx adapter [ upstream commit e846cfdec34cc58b9a1a2438d313028246b8e986 ] In the eth Rx adapter SW service function, move the return to after the spinlock unlock. Coverity issue: 302857 Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop") Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index 71d008cd1..8831bc35f 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -1166,6 +1166,6 @@ rxa_service_func(void *args) return 0; if (!rx_adapter->rxa_started) { - return 0; rte_spinlock_unlock(&rx_adapter->rx_lock); + return 0; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:36.849926990 +0000 +++ 0072-eventdev-fix-unlock-in-Rx-adapter.patch 2018-11-29 13:11:34.000000000 +0000 @@ -1,14 +1,15 @@ -From e846cfdec34cc58b9a1a2438d313028246b8e986 Mon Sep 17 00:00:00 2001 +From 51c4f7b40b7532c02a398fa19d5dfb183cd2e9fb Mon Sep 17 00:00:00 2001 From: Nikhil Rao Date: Wed, 21 Nov 2018 03:39:15 +0530 Subject: [PATCH] eventdev: fix unlock in Rx adapter +[ upstream commit e846cfdec34cc58b9a1a2438d313028246b8e986 ] + In the eth Rx adapter SW service function, move the return to after the spinlock unlock. Coverity issue: 302857 Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop") -Cc: stable@dpdk.org Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob