From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 50BF71B4AA for ; Thu, 29 Nov 2018 14:24:16 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B66993086260; Thu, 29 Nov 2018 13:24:15 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADAA81001F50; Thu, 29 Nov 2018 13:24:14 +0000 (UTC) From: Kevin Traynor To: Yanglong Wu Cc: Qi Zhang , dpdk stable Date: Thu, 29 Nov 2018 13:21:18 +0000 Message-Id: <20181129132128.7609-78-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 29 Nov 2018 13:24:15 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ixgbe: fix TDH register write' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:24:16 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From c17e2a231e0f1605711fca1d9415b1d46bea5747 Mon Sep 17 00:00:00 2001 From: Yanglong Wu Date: Tue, 20 Nov 2018 13:59:21 +0800 Subject: [PATCH] net/ixgbe: fix TDH register write [ upstream commit ff30a020bb400f04bf64a91416993862f45f9ada ] The only time that software should write to the TDH register is after a reset (hardware reset or CTRL.RST) and before enabling the transmit function (TXDCTL.ENABLE). If software were to write to this register while the transmit function was enabled, the on-chip descriptor buffers might be invalidated and the hardware could become confused. Fixes: 029fd06d40fa ("ixgbe: queue start and stop") Signed-off-by: Yanglong Wu Acked-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 792727353..4bfd2a422 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5265,4 +5265,5 @@ ixgbe_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) txq = dev->data->tx_queues[tx_queue_id]; + IXGBE_WRITE_REG(hw, IXGBE_TDH(txq->reg_idx), 0); txdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(txq->reg_idx)); txdctl |= IXGBE_TXDCTL_ENABLE; @@ -5282,5 +5283,4 @@ ixgbe_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id) } rte_wmb(); - IXGBE_WRITE_REG(hw, IXGBE_TDH(txq->reg_idx), 0); IXGBE_WRITE_REG(hw, IXGBE_TDT(txq->reg_idx), 0); dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:36.967718855 +0000 +++ 0077-net-ixgbe-fix-TDH-register-write.patch 2018-11-29 13:11:35.000000000 +0000 @@ -1,8 +1,10 @@ -From ff30a020bb400f04bf64a91416993862f45f9ada Mon Sep 17 00:00:00 2001 +From c17e2a231e0f1605711fca1d9415b1d46bea5747 Mon Sep 17 00:00:00 2001 From: Yanglong Wu Date: Tue, 20 Nov 2018 13:59:21 +0800 Subject: [PATCH] net/ixgbe: fix TDH register write +[ upstream commit ff30a020bb400f04bf64a91416993862f45f9ada ] + The only time that software should write to the TDH register is after a reset (hardware reset or CTRL.RST) and before enabling the transmit function (TXDCTL.ENABLE). @@ -11,7 +13,6 @@ be invalidated and the hardware could become confused. Fixes: 029fd06d40fa ("ixgbe: queue start and stop") -Cc: stable@dpdk.org Signed-off-by: Yanglong Wu Acked-by: Qi Zhang @@ -20,7 +21,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c -index 2f0262ae1..ddc7efa87 100644 +index 792727353..4bfd2a422 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5265,4 +5265,5 @@ ixgbe_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)