From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 537A31B4AA for ; Thu, 29 Nov 2018 14:24:31 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1B9D753E2; Thu, 29 Nov 2018 13:24:30 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-230.ams2.redhat.com [10.36.117.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC1951019626; Thu, 29 Nov 2018 13:24:28 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Stephen Hemminger , Andrew Rybchenko , Maxime Coquelin , dpdk stable Date: Thu, 29 Nov 2018 13:21:23 +0000 Message-Id: <20181129132128.7609-83-ktraynor@redhat.com> In-Reply-To: <20181129132128.7609-1-ktraynor@redhat.com> References: <20181129132128.7609-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 29 Nov 2018 13:24:30 +0000 (UTC) Subject: [dpdk-stable] patch 'bus/pci: fix allocation of device path' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 13:24:31 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/08/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 10d64262b89b1634e53bb6b56e2b25087bfba81e Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 23 Nov 2018 00:29:45 +0000 Subject: [PATCH] bus/pci: fix allocation of device path [ upstream commit d3110b124af64199b0901223c7e0117f7480480f ] The pci_resource_by_index called strlen() on uninitialized memory which would lead to the wrong size of memory allocated for the path portion of the resource map. This would either cause excessively large allocation, or worse memory corruption. Coverity issue: 300868 Fixes: ea9d56226e72 ("pci: introduce function to map uio resource by index") Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin --- drivers/bus/pci/linux/pci_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c index a7c14421a..09ecbb7aa 100644 --- a/drivers/bus/pci/linux/pci_uio.c +++ b/drivers/bus/pci/linux/pci_uio.c @@ -297,5 +297,5 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx, /* allocate memory to keep path */ - maps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0); + maps[map_idx].path = rte_malloc(NULL, sizeof(devname), 0); if (maps[map_idx].path == NULL) { RTE_LOG(ERR, EAL, "Cannot allocate memory for path: %s\n", -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 13:11:37.086630963 +0000 +++ 0082-bus-pci-fix-allocation-of-device-path.patch 2018-11-29 13:11:35.000000000 +0000 @@ -1,8 +1,10 @@ -From d3110b124af64199b0901223c7e0117f7480480f Mon Sep 17 00:00:00 2001 +From 10d64262b89b1634e53bb6b56e2b25087bfba81e Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 23 Nov 2018 00:29:45 +0000 Subject: [PATCH] bus/pci: fix allocation of device path +[ upstream commit d3110b124af64199b0901223c7e0117f7480480f ] + The pci_resource_by_index called strlen() on uninitialized memory which would lead to the wrong size of memory allocated for the path portion of the resource map. This would either cause @@ -10,7 +12,6 @@ Coverity issue: 300868 Fixes: ea9d56226e72 ("pci: introduce function to map uio resource by index") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Signed-off-by: Ferruh Yigit