From: Yongseok Koh <yskoh@mellanox.com>
To: Mark Spender <mspender@solarflare.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/sfc/base: prevent access to the NIC config before probe' has been queued to LTS release 17.11.5
Date: Thu, 29 Nov 2018 15:10:14 -0800 [thread overview]
Message-ID: <20181129231202.30436-20-yskoh@mellanox.com> (raw)
In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com>
Hi,
FYI, your patch has been queued to LTS release 17.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/01/18. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Yongseok
---
>From fca876a58f97d8adaac4f22058794cae1996e9b5 Mon Sep 17 00:00:00 2001
From: Mark Spender <mspender@solarflare.com>
Date: Mon, 10 Sep 2018 10:33:26 +0100
Subject: [PATCH] net/sfc/base: prevent access to the NIC config before probe
[ upstream commit f78fb0a8e1c78cc3ffcdd0a6b72f6aa200e980ee ]
NIC config is initialized during NIC probe.
Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base")
Signed-off-by: Mark Spender <mspender@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/efx_nic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/sfc/base/efx_nic.c b/drivers/net/sfc/base/efx_nic.c
index adc62341c..a18cb364a 100644
--- a/drivers/net/sfc/base/efx_nic.c
+++ b/drivers/net/sfc/base/efx_nic.c
@@ -612,6 +612,7 @@ efx_nic_cfg_get(
__in efx_nic_t *enp)
{
EFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);
+ EFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_PROBE);
return (&(enp->en_nic_cfg));
}
--
2.11.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2018-11-29 15:01:46.167417701 -0800
+++ 0020-net-sfc-base-prevent-access-to-the-NIC-config-before.patch 2018-11-29 15:01:45.003965000 -0800
@@ -1,12 +1,13 @@
-From f78fb0a8e1c78cc3ffcdd0a6b72f6aa200e980ee Mon Sep 17 00:00:00 2001
+From fca876a58f97d8adaac4f22058794cae1996e9b5 Mon Sep 17 00:00:00 2001
From: Mark Spender <mspender@solarflare.com>
Date: Mon, 10 Sep 2018 10:33:26 +0100
Subject: [PATCH] net/sfc/base: prevent access to the NIC config before probe
+[ upstream commit f78fb0a8e1c78cc3ffcdd0a6b72f6aa200e980ee ]
+
NIC config is initialized during NIC probe.
Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base")
-Cc: stable@dpdk.org
Signed-off-by: Mark Spender <mspender@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
@@ -15,10 +16,10 @@
1 file changed, 1 insertion(+)
diff --git a/drivers/net/sfc/base/efx_nic.c b/drivers/net/sfc/base/efx_nic.c
-index e5cb0105f..cea32b792 100644
+index adc62341c..a18cb364a 100644
--- a/drivers/net/sfc/base/efx_nic.c
+++ b/drivers/net/sfc/base/efx_nic.c
-@@ -595,6 +595,7 @@ efx_nic_cfg_get(
+@@ -612,6 +612,7 @@ efx_nic_cfg_get(
__in efx_nic_t *enp)
{
EFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);
next prev parent reply other threads:[~2018-11-29 23:13 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:09 [dpdk-stable] patch 'net/mlx5: add Bluefield device id' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'eal/arm64: fix instrinsic for GCC < 4.9' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'mem: fix memory initialization time' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'build: enable ARM NEON flag when __aarch64__ defined' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'acl: forbid rule with priority zero' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: support matching QinQ ethertype' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: fix wrong usage of bind command' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'examples/vhost: remove unnecessary constant' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: use evenly distributed default RSS RETA' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: do not ignore RSS key on device config' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: optimize mbuf pool allocation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/nfp: fix mbuf flags with checksum good' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net: fix Intel prepare function for IP checksum offload' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix SAL annotation for input buffers' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: properly align on line continuation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix build because of no declaration' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: check size of memory to read sensors data to' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: avoid usage of too big arrays on stack' " Yongseok Koh
2018-11-29 23:10 ` Yongseok Koh [this message]
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix a typo in unicast filter insertion comment' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix MAC Tx stats for less or equal to 64 bytes' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc: fix an Rx queue double release possibility' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc: fix a Tx " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: fix Rx slave fairness' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/failsafe: remove not supported multicast MAC filter' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: make last byte of module information available' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'ethdev: fix doxygen comment to be with structure' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: stop and deactivate slaves on stop' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/test-crypto-perf: fix check for auth key' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/test-crypto-perf: fix check for cipher IV' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/test-crypto-perf: fix double allocation of memory' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'crypto/aesni_mb: fix possible array overrun' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'test/crypto: fix number of queue pairs' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'event/sw: fix cq index check for unlink usecases' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'test/event: check burst mode capability' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'mem: fix undefined behavior in NUMA-aware mapping' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'igb_uio: fix refcount if open returns error' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e: fix send admin queue command before init' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e/base: properly clean resources' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e/base: gracefully clean the " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e/base: correct global reset timeout calculation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/ixgbe: wait longer for link after fiber MAC setup' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/enic: do not use non-standard integer types' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/enic: set Rx VLAN offload flag for non-stripped packets' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/nfp: fix RSS' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnx2x: fix to disable further interrupts' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnx2x: fix call to link handling periodic function' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/enic: fix flow API memory leak' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: fix uninitialized pointer access in Tx' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: fix registration of VF async event completion ring' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: set MAC filtering as outer for non tunnel frames' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: set VLAN strip mode before default VNIC cfg' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: fix csum parse-tunnel command invocation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc: receive prepared packets even in Rx exception case' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'mbuf: fix Tx offload mask' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: clarify L3 Tx checksum prerequisite' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: clarify L4 " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/failsafe: use prefix for function' " Yongseok Koh
2018-12-20 0:17 ` Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: add VFIO in ENA guide' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: fix printf format in event callback' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: fix duplicate exit' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/e1000: do not error out if Rx drop enable is set' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'eal: use correct data type for bitmap slab operations' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'crypto/mvsam: update hash digest sizes' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: fix vdev socket initialization' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: fix physical port " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kvargs: fix processing a null list' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'igb_uio: fix unexpected removal for hot-unplug' " Yongseok Koh
2018-12-20 0:18 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'latency: fix timestamp marking and latency calculation' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test/hash: fix bucket size in perf test' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix build on Linux 4.19' " Yongseok Koh
2018-12-20 0:19 ` Yongseok Koh
2019-01-04 20:33 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix kernel FIFO synchronization' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix build on Linux < 3.14' " Yongseok Koh
2018-12-20 0:19 ` Yongseok Koh
2018-12-20 8:30 ` Thomas Monjalon
2018-12-28 9:25 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: reserve NUMA node per port and per ring' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: keep promiscuous on if allmulticast is enabled' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: enable loopback function for X722 MAC' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: update Tx offload mask' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ixgbe: " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ena: fix passing RSS hash to mbuf' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix typo in testpmd guide' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'ip_frag: fix overflow in key comparison' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: support strlcpy function' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal/linux: fix memory leak of logid' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/virtio: fix PCI config error handling' " Yongseok Koh
2018-11-30 15:23 ` Tiwei Bie
2018-11-30 18:02 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'bus/pci: compare kernel driver instead of interrupt handler' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal/linux: handle UIO read failure in " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'mk: disable gcc AVX512F support' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'crypto/scheduler: fix build with gcc 8.2' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: fix build with gcc 9.0' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: fix offload not supported mask' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net: fix build with pedantic' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: clarify TSO Tx offload prerequisite' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/igb: update Tx offload mask' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'ip_frag: use key length for key comparison' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'bus/pci: fix config r/w access' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test/hash: fix build' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: introduce rte version of fls' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: fix build' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'pci: fix parsing of address without function number' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/tap: fix file descriptor check' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/e1000/base: fix uninitialized variable' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/mlx5: fix build on PPC64' " Yongseok Koh
2018-12-20 0:20 ` Yongseok Koh
2018-12-20 8:34 ` Thomas Monjalon
2018-11-29 23:11 ` [dpdk-stable] patch 'net/thunderx: fix Tx desc corruption in scatter-gather mode' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/virtio-user: fix typo in error message' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/virtio: fix unchecked return value' " Yongseok Koh
2018-11-30 15:23 ` Tiwei Bie
2018-11-30 18:01 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'vhost: remove unneeded null pointer check' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/bonding: fix crash when stopping mode 4 port' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/qede: fix crash when configure fails' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: fix L4 length for UDP checksum' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ixgbevf: fix link state' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test/reorder: fix out of bound access' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'efd: fix write unlock during ring creation' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: fix X710 Rx after reading some registers' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ixgbe: fix maximum wait time in comment' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'examples/ipv4_multicast: fix leak of cloned packets' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test: release ring resources after PMD perf test' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'usertools: check for lspci dependency' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix NUMA library name in Linux guide' " Yongseok Koh
2018-12-20 0:21 ` Yongseok Koh
2019-01-08 16:48 ` Burakov, Anatoly
2019-01-08 18:51 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix formatting in IP reassembly app " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix function name in flow filtering " Yongseok Koh
2018-12-20 0:21 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: fix build with -O1' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix possible uninitialized variable' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e/base: fix comment referencing internal data' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/qede: fix Tx offload mask' " Yongseok Koh
2018-11-29 23:12 ` [dpdk-stable] patch 'bus/pci: fix allocation of device path' " Yongseok Koh
2018-11-29 23:12 ` [dpdk-stable] patch 'vfio: do not needlessly setup device in secondary process' " Yongseok Koh
2018-12-20 0:22 ` Yongseok Koh
2019-01-08 16:47 ` Burakov, Anatoly
2019-01-08 18:50 ` Yongseok Koh
2019-01-09 8:53 ` Burakov, Anatoly
2018-11-29 23:12 ` [dpdk-stable] patch 'eal: fix devargs reference after probing failure' " Yongseok Koh
2018-12-20 0:22 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129231202.30436-20-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=mspender@solarflare.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).