From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 00E461B518 for ; Fri, 30 Nov 2018 00:13:25 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:19:18 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW7U032075; Fri, 30 Nov 2018 01:13:23 +0200 From: Yongseok Koh To: Anoob Joseph Cc: Ayuj Verma , Akhil Goyal , dpdk stable Date: Thu, 29 Nov 2018 15:10:24 -0800 Message-Id: <20181129231202.30436-30-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'app/test-crypto-perf: fix check for auth key' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:13:26 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 845486a3a80fe6e8bc1ae9a7049a3b483e6fe124 Mon Sep 17 00:00:00 2001 From: Anoob Joseph Date: Fri, 14 Sep 2018 14:54:47 +0530 Subject: [PATCH] app/test-crypto-perf: fix check for auth key [ upstream commit c864167ce97d91ed95c68f8f85cf2dbaaae212d3 ] Authentication key is not required for all algorithms. Making sure the null check is done only when 'auth_key_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 13e012188..fb5d6ebe3 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -339,7 +339,9 @@ cperf_check_test_vector(struct cperf_options *opts, return -1; if (test_vec->plaintext.length < opts->max_buffer_size) return -1; - if (test_vec->auth_key.data == NULL) + /* Auth key is only required for some algorithms */ + if (opts->auth_key_sz && + test_vec->auth_key.data == NULL) return -1; if (test_vec->auth_key.length != opts->auth_key_sz) return -1; -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:46.586179694 -0800 +++ 0030-app-test-crypto-perf-fix-check-for-auth-key.patch 2018-11-29 15:01:45.037966000 -0800 @@ -1,13 +1,14 @@ -From c864167ce97d91ed95c68f8f85cf2dbaaae212d3 Mon Sep 17 00:00:00 2001 +From 845486a3a80fe6e8bc1ae9a7049a3b483e6fe124 Mon Sep 17 00:00:00 2001 From: Anoob Joseph Date: Fri, 14 Sep 2018 14:54:47 +0530 Subject: [PATCH] app/test-crypto-perf: fix check for auth key +[ upstream commit c864167ce97d91ed95c68f8f85cf2dbaaae212d3 ] + Authentication key is not required for all algorithms. Making sure the null check is done only when 'auth_key_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") -Cc: stable@dpdk.org Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma @@ -17,10 +18,10 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c -index c9f99a76d..55d97c26b 100644 +index 13e012188..fb5d6ebe3 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c -@@ -357,7 +357,9 @@ cperf_check_test_vector(struct cperf_options *opts, +@@ -339,7 +339,9 @@ cperf_check_test_vector(struct cperf_options *opts, return -1; if (test_vec->plaintext.length < opts->max_buffer_size) return -1;