From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 21ACE1B512 for ; Fri, 30 Nov 2018 00:13:36 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:19:29 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW7a032075; Fri, 30 Nov 2018 01:13:33 +0200 From: Yongseok Koh To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk stable Date: Thu, 29 Nov 2018 15:10:30 -0800 Message-Id: <20181129231202.30436-36-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'test/event: check burst mode capability' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:13:36 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 4f414cb7c85d75c4791ff889bbe60d45be6f2485 Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Wed, 5 Sep 2018 19:53:31 +0530 Subject: [PATCH] test/event: check burst mode capability [ upstream commit 6fe63a3d7ccc2e2376182f663251f42add77ec40 ] Enqueue, dequeue depths are only valid for event devs that have burst mode capability. Check event dev capability before testing depth boundary. Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- test/test/test_eventdev.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c index 1ed2a1ddd..d51f94c3f 100644 --- a/test/test/test_eventdev.c +++ b/test/test/test_eventdev.c @@ -218,15 +218,18 @@ test_eventdev_configure(void) "Config negative test failed"); TEST_ASSERT_EQUAL(-EINVAL, test_ethdev_config_run(&dev_conf, &info, max_event_queue_flows), - "Config negative test failed"); - TEST_ASSERT_EQUAL(-EINVAL, - test_ethdev_config_run(&dev_conf, &info, - max_event_port_dequeue_depth), - "Config negative test failed"); - TEST_ASSERT_EQUAL(-EINVAL, - test_ethdev_config_run(&dev_conf, &info, - max_event_port_enqueue_depth), - "Config negative test failed"); + "Config negative test failed"); + + if (info.event_dev_cap & RTE_EVENT_DEV_CAP_BURST_MODE) { + TEST_ASSERT_EQUAL(-EINVAL, + test_ethdev_config_run(&dev_conf, &info, + max_event_port_dequeue_depth), + "Config negative test failed"); + TEST_ASSERT_EQUAL(-EINVAL, + test_ethdev_config_run(&dev_conf, &info, + max_event_port_enqueue_depth), + "Config negative test failed"); + } /* Positive case */ devconf_set_default_sane_values(&dev_conf, &info); -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:46.841019957 -0800 +++ 0036-test-event-check-burst-mode-capability.patch 2018-11-29 15:01:45.054961000 -0800 @@ -1,14 +1,15 @@ -From 6fe63a3d7ccc2e2376182f663251f42add77ec40 Mon Sep 17 00:00:00 2001 +From 4f414cb7c85d75c4791ff889bbe60d45be6f2485 Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Wed, 5 Sep 2018 19:53:31 +0530 Subject: [PATCH] test/event: check burst mode capability +[ upstream commit 6fe63a3d7ccc2e2376182f663251f42add77ec40 ] + Enqueue, dequeue depths are only valid for event devs that have burst mode capability. Check event dev capability before testing depth boundary. Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") -Cc: stable@dpdk.org Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob @@ -17,10 +18,10 @@ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c -index 04bdc6b6c..00d73275c 100644 +index 1ed2a1ddd..d51f94c3f 100644 --- a/test/test/test_eventdev.c +++ b/test/test/test_eventdev.c -@@ -190,15 +190,18 @@ test_eventdev_configure(void) +@@ -218,15 +218,18 @@ test_eventdev_configure(void) "Config negative test failed"); TEST_ASSERT_EQUAL(-EINVAL, test_ethdev_config_run(&dev_conf, &info, max_event_queue_flows),