From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 680A01B51A for ; Fri, 30 Nov 2018 00:12:41 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:18:34 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW74032075; Fri, 30 Nov 2018 01:12:38 +0200 From: Yongseok Koh To: Honnappa Nagarahalli Cc: Raslan Darawsheh , Thomas F Herbert , Phil Yang , Gavin Hu , Jerin Jacob , dpdk stable Date: Thu, 29 Nov 2018 15:09:58 -0800 Message-Id: <20181129231202.30436-4-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'build: enable ARM NEON flag when __aarch64__ defined' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:12:41 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From b2191d0999b615ee8b74bc918c7aa4ffc9deda23 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Sun, 2 Sep 2018 13:35:28 -0500 Subject: [PATCH] build: enable ARM NEON flag when __aarch64__ defined [ backported from upstream commit 68acaa86ae639e3cdd94e419f546045a1b0ce6ca ] GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional for ArmV8. Hence NEON related code can be enabled when __aarch64__ is defined. Bugzilla ID: 82 Reported-by: Raslan Darawsheh Reported-by: Thomas F Herbert Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Gavin Hu Acked-by: Jerin Jacob --- mk/rte.cpuflags.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index a813c91f4..64caa3dbc 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -117,7 +117,7 @@ CPUFLAGS += VSX endif # ARM flags -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) CPUFLAGS += NEON endif -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:45.489297769 -0800 +++ 0004-build-enable-ARM-NEON-flag-when-__aarch64__-defined.patch 2018-11-29 15:01:44.963961000 -0800 @@ -1,14 +1,15 @@ -From 68acaa86ae639e3cdd94e419f546045a1b0ce6ca Mon Sep 17 00:00:00 2001 +From b2191d0999b615ee8b74bc918c7aa4ffc9deda23 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Sun, 2 Sep 2018 13:35:28 -0500 Subject: [PATCH] build: enable ARM NEON flag when __aarch64__ defined +[ backported from upstream commit 68acaa86ae639e3cdd94e419f546045a1b0ce6ca ] + GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional for ArmV8. Hence NEON related code can be enabled when __aarch64__ is defined. Bugzilla ID: 82 -Cc: stable@dpdk.org Reported-by: Raslan Darawsheh Reported-by: Thomas F Herbert @@ -17,29 +18,14 @@ Reviewed-by: Gavin Hu Acked-by: Jerin Jacob --- - config/arm/meson.build | 3 ++- - mk/rte.cpuflags.mk | 2 +- - 2 files changed, 3 insertions(+), 2 deletions(-) + mk/rte.cpuflags.mk | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/config/arm/meson.build b/config/arm/meson.build -index 40dbc87f7..94cca490e 100644 ---- a/config/arm/meson.build -+++ b/config/arm/meson.build -@@ -157,7 +157,8 @@ else - endif - message(machine_args) - --if cc.get_define('__ARM_NEON', args: machine_args) != '' -+if (cc.get_define('__ARM_NEON', args: machine_args) != '' or -+ cc.get_define('__aarch64__', args: machine_args) != '') - dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) - compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] - endif diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk -index 60713137d..43ed84155 100644 +index a813c91f4..64caa3dbc 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk -@@ -89,7 +89,7 @@ CPUFLAGS += VSX +@@ -117,7 +117,7 @@ CPUFLAGS += VSX endif # ARM flags