From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 232A11B517 for ; Fri, 30 Nov 2018 00:14:36 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:20:28 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW8B032075; Fri, 30 Nov 2018 01:14:32 +0200 From: Yongseok Koh To: Yipeng Wang Cc: Bruce Richardson , Honnappa Nagarahalli , dpdk stable Date: Thu, 29 Nov 2018 15:11:05 -0800 Message-Id: <20181129231202.30436-71-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'test/hash: fix bucket size in perf test' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:14:36 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 8957443b6d7a6c3926a2f967e179108c0fbe8754 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 28 Sep 2018 07:11:05 -0700 Subject: [PATCH] test/hash: fix bucket size in perf test [ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ] The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket size set to 4, it mismatches the underneath rte_hash structure, which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- test/test/test_hash_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index c0051b20f..b0514b104 100644 --- a/test/test/test_hash_perf.c +++ b/test/test/test_hash_perf.c @@ -49,7 +49,8 @@ #define MAX_ENTRIES (1 << 19) #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */ -#define BUCKET_SIZE 4 +/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */ +#define BUCKET_SIZE 8 #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) #define MAX_KEYSIZE 64 #define NUM_KEYSIZES 10 -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:48.347606529 -0800 +++ 0071-test-hash-fix-bucket-size-in-perf-test.patch 2018-11-29 15:01:45.179958000 -0800 @@ -1,8 +1,10 @@ -From b772a15eb84ce616114880a20ad6ad91bb8970fc Mon Sep 17 00:00:00 2001 +From 8957443b6d7a6c3926a2f967e179108c0fbe8754 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 28 Sep 2018 07:11:05 -0700 Subject: [PATCH] test/hash: fix bucket size in perf test +[ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ] + The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. @@ -16,7 +18,6 @@ which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") -Cc: stable@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson @@ -26,10 +27,10 @@ 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c -index 33dcb9fcf..fe116326d 100644 +index c0051b20f..b0514b104 100644 --- a/test/test/test_hash_perf.c +++ b/test/test/test_hash_perf.c -@@ -20,7 +20,8 @@ +@@ -49,7 +49,8 @@ #define MAX_ENTRIES (1 << 19) #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */