From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yskoh@mellanox.com> Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 34C03322C for <stable@dpdk.org>; Fri, 30 Nov 2018 00:14:46 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:20:36 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW8G032075; Fri, 30 Nov 2018 01:14:41 +0200 From: Yongseok Koh <yskoh@mellanox.com> To: Huaibin Wang <huaibin.wang@6wind.com> Cc: Laurent Hardy <laurent.hardy@6wind.com>, Qi Zhang <qi.z.zhang@intel.com>, dpdk stable <stable@dpdk.org> Date: Thu, 29 Nov 2018 15:11:10 -0800 Message-Id: <20181129231202.30436-76-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/i40e: keep promiscuous on if allmulticast is enabled' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 29 Nov 2018 23:14:46 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 1801908e55a4f801a3129d9fb544711d1049cc6e Mon Sep 17 00:00:00 2001 From: Huaibin Wang <huaibin.wang@6wind.com> Date: Fri, 19 Oct 2018 11:45:21 +0200 Subject: [PATCH] net/i40e: keep promiscuous on if allmulticast is enabled [ upstream commit 815037b92b3437754183fb256a967a7e82d3820a ] Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. Signed-off-by: Huaibin Wang <huaibin.wang@6wind.com> Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/i40e/i40e_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 9d99e841e..5bbc3c44b 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2419,6 +2419,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); + /* must remain in all_multicast mode */ + if (dev->data->all_multicast == 1) + return; + status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, false, NULL); if (status != I40E_SUCCESS) -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:48.566486364 -0800 +++ 0076-net-i40e-keep-promiscuous-on-if-allmulticast-is-enab.patch 2018-11-29 15:01:45.197958000 -0800 @@ -1,15 +1,15 @@ -From 815037b92b3437754183fb256a967a7e82d3820a Mon Sep 17 00:00:00 2001 +From 1801908e55a4f801a3129d9fb544711d1049cc6e Mon Sep 17 00:00:00 2001 From: Huaibin Wang <huaibin.wang@6wind.com> Date: Fri, 19 Oct 2018 11:45:21 +0200 Subject: [PATCH] net/i40e: keep promiscuous on if allmulticast is enabled +[ upstream commit 815037b92b3437754183fb256a967a7e82d3820a ] + Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. -Cc: stable@dpdk.org - Signed-off-by: Huaibin Wang <huaibin.wang@6wind.com> Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> @@ -18,10 +18,10 @@ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c -index f7a685c8c..6c503debc 100644 +index 9d99e841e..5bbc3c44b 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c -@@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) +@@ -2419,6 +2419,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous");