From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 755311B51A for ; Fri, 30 Nov 2018 00:15:06 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:20:59 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW8U032075; Fri, 30 Nov 2018 01:15:04 +0200 From: Yongseok Koh To: Ferruh Yigit Cc: dpdk stable Date: Thu, 29 Nov 2018 15:11:24 -0800 Message-Id: <20181129231202.30436-90-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal: fix build with gcc 9.0' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:15:06 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 18423d4380d52616653d390a42faa7b700a4775c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 2 Nov 2018 19:06:06 +0000 Subject: [PATCH] eal: fix build with gcc 9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 3370975b994d793a89812031d86534916067dd67 ] build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: error: ‘strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Werror=stringop-truncation] strncpy(solib->name, path, PATH_MAX-1); strncpy may result a not null-terminated string, replaced it with strlcpy Fixes: f9a08f650211 ("eal: add support for shared object drivers") Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 996a03424..c7eb056b2 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -232,7 +232,7 @@ eal_plugin_add(const char *path) return -1; } memset(solib, 0, sizeof(*solib)); - strncpy(solib->name, path, PATH_MAX-1); + strlcpy(solib->name, path, PATH_MAX-1); solib->name[PATH_MAX-1] = 0; TAILQ_INSERT_TAIL(&solib_list, solib, next); -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:49.174883033 -0800 +++ 0090-eal-fix-build-with-gcc-9.0.patch 2018-11-29 15:01:45.242960000 -0800 @@ -1,4 +1,4 @@ -From 3370975b994d793a89812031d86534916067dd67 Mon Sep 17 00:00:00 2001 +From 18423d4380d52616653d390a42faa7b700a4775c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 2 Nov 2018 19:06:06 +0000 Subject: [PATCH] eal: fix build with gcc 9.0 @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 3370975b994d793a89812031d86534916067dd67 ] + build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: @@ -17,7 +19,6 @@ replaced it with strlcpy Fixes: f9a08f650211 ("eal: add support for shared object drivers") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- @@ -25,10 +26,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c -index b82f3ddd1..e31eca5c0 100644 +index 996a03424..c7eb056b2 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c -@@ -222,7 +222,7 @@ eal_plugin_add(const char *path) +@@ -232,7 +232,7 @@ eal_plugin_add(const char *path) return -1; } memset(solib, 0, sizeof(*solib));