patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx adapter
@ 2018-11-29  8:00 Nikhil Rao
  2018-11-29  8:53 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Nikhil Rao @ 2018-11-29  8:00 UTC (permalink / raw)
  To: jerin.jacob; +Cc: dev, Nikhil Rao, stable

strerror() input parameter should be > 0.

Coverity issue: 302864

Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 8831bc35f..8d178be15 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -912,7 +912,7 @@ rxa_intr_ring_enqueue(struct rte_event_eth_rx_adapter *rx_adapter,
 		 */
 		if (err)
 			RTE_EDEV_LOG_ERR("Failed to enqueue interrupt"
-				" to ring: %s", strerror(err));
+				" to ring: %s", strerror(-err));
 		else
 			rte_eth_dev_rx_intr_disable(port_id, queue);
 	}
-- 
2.14.1.145.gb3622a4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx adapter
  2018-11-29  8:00 [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx adapter Nikhil Rao
@ 2018-11-29  8:53 ` Ferruh Yigit
  2018-12-01 14:09   ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-29  8:53 UTC (permalink / raw)
  To: Nikhil Rao, jerin.jacob; +Cc: dev, stable

On 11/29/2018 8:00 AM, Nikhil Rao wrote:
> strerror() input parameter should be > 0.
> 
> Coverity issue: 302864
> Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx adapter
  2018-11-29  8:53 ` Ferruh Yigit
@ 2018-12-01 14:09   ` Jerin Jacob
  0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2018-12-01 14:09 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: Nikhil Rao, dev, stable

-----Original Message-----
> Date: Thu, 29 Nov 2018 08:53:30 +0000
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Nikhil Rao <nikhil.rao@intel.com>, jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx
>  adapter
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
>  Thunderbird/60.3.1
> 
> 
> On 11/29/2018 8:00 AM, Nikhil Rao wrote:
> > strerror() input parameter should be > 0.
> >
> > Coverity issue: 302864
> > Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-eventdev/master. Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-01 14:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-29  8:00 [dpdk-stable] [PATCH] eventdev: fix call to strerror in eth Rx adapter Nikhil Rao
2018-11-29  8:53 ` Ferruh Yigit
2018-12-01 14:09   ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).