From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C28CA1B8B8 for ; Fri, 14 Dec 2018 19:25:28 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FDA5A8C1B; Fri, 14 Dec 2018 18:25:28 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-116-106.ams2.redhat.com [10.36.116.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE8AA600C0; Fri, 14 Dec 2018 18:25:26 +0000 (UTC) From: Kevin Traynor To: Xiaoyun Li Cc: Qi Zhang , dpdk stable Date: Fri, 14 Dec 2018 18:24:14 +0000 Message-Id: <20181214182430.11593-12-ktraynor@redhat.com> In-Reply-To: <20181214182430.11593-1-ktraynor@redhat.com> References: <20181214182430.11593-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 14 Dec 2018 18:25:28 +0000 (UTC) Subject: [dpdk-stable] patch 'net/i40e: fix using recovery mode firmware' has been queued to stable release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 18:25:29 -0000 Hi, FYI, your patch has been queued to stable release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/18/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 30e3081f66e6553f468cd42d6d320666d3cc49c9 Mon Sep 17 00:00:00 2001 From: Xiaoyun Li Date: Mon, 3 Dec 2018 15:07:46 +0800 Subject: [PATCH] net/i40e: fix using recovery mode firmware [ upstream commit 81b531cfc235149f68a40842abf0767a4fbfe994 ] Device can't function properly with a firmware that is in recovery mode. Check the firmware status at initialization time. If the firmware is in recovery mode, alert the user to check it. Signed-off-by: Xiaoyun Li Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 552a7a566..f61a12eb2 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1274,5 +1274,5 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) struct i40e_vsi *vsi; int ret; - uint32_t len; + uint32_t len, val; uint8_t aq_fail = 0; @@ -1325,4 +1325,13 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) hw->switch_tag = 0xffff; + val = I40E_READ_REG(hw, I40E_GL_FWSTS); + if (val & I40E_GL_FWSTS_FWS1B_MASK) { + PMD_INIT_LOG(ERR, "\nERROR: " + "Firmware recovery mode detected. Limiting functionality.\n" + "Refer to the Intel(R) Ethernet Adapters and Devices " + "User Guide for details on firmware recovery mode."); + return -EIO; + } + /* Check if need to support multi-driver */ i40e_support_multi_driver(dev); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-12-14 18:23:18.546741837 +0000 +++ 0012-net-i40e-fix-using-recovery-mode-firmware.patch 2018-12-14 18:23:18.000000000 +0000 @@ -1,16 +1,16 @@ -From 81b531cfc235149f68a40842abf0767a4fbfe994 Mon Sep 17 00:00:00 2001 +From 30e3081f66e6553f468cd42d6d320666d3cc49c9 Mon Sep 17 00:00:00 2001 From: Xiaoyun Li Date: Mon, 3 Dec 2018 15:07:46 +0800 Subject: [PATCH] net/i40e: fix using recovery mode firmware +[ upstream commit 81b531cfc235149f68a40842abf0767a4fbfe994 ] + Device can't function properly with a firmware that is in recovery mode. Check the firmware status at initialization time. If the firmware is in recovery mode, alert the user to check it. -Cc: stable@dpdk.org - Signed-off-by: Xiaoyun Li Acked-by: Qi Zhang ---