From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F09961B903 for ; Fri, 14 Dec 2018 19:25:57 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B76E3E2CE; Fri, 14 Dec 2018 18:25:57 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-116-106.ams2.redhat.com [10.36.116.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1888D600C0; Fri, 14 Dec 2018 18:25:55 +0000 (UTC) From: Kevin Traynor To: Zhirun Yan Cc: Haiyue Wang , Qi Zhang , dpdk stable Date: Fri, 14 Dec 2018 18:24:30 +0000 Message-Id: <20181214182430.11593-28-ktraynor@redhat.com> In-Reply-To: <20181214182430.11593-1-ktraynor@redhat.com> References: <20181214182430.11593-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 14 Dec 2018 18:25:57 +0000 (UTC) Subject: [dpdk-stable] patch 'net/i40e: remove redundant reset of queue number' has been queued to stable release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 18:25:58 -0000 Hi, FYI, your patch has been queued to stable release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/18/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From ae2b6e88781f2dba8f5e697d02d91ff1d59500d6 Mon Sep 17 00:00:00 2001 From: Zhirun Yan Date: Thu, 13 Dec 2018 12:49:28 +0000 Subject: [PATCH] net/i40e: remove redundant reset of queue number [ upstream commit ef8b7c505f10897621c0801d8ef3e961385246f8 ] Before this patch, there are two functions will call i40e_dev_free_queues to free queues. For rte_eth_dev_close(), its redundant because of duplication. For rte_eth_dev_reset() its redundant because of not necessary, since following dev_configure is required after dev_reset and it will be updated correctly. This patch removes redundant code in i40e_dev_free_queues(). Fixes: 6b4537128394 ("i40e: free queue memory when closing") Signed-off-by: Zhirun Yan Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/net/i40e/i40e_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index ab74a488f..82a170929 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2754,5 +2754,4 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) dev->data->rx_queues[i] = NULL; } - dev->data->nb_rx_queues = 0; for (i = 0; i < dev->data->nb_tx_queues; i++) { @@ -2762,5 +2761,4 @@ i40e_dev_free_queues(struct rte_eth_dev *dev) dev->data->tx_queues[i] = NULL; } - dev->data->nb_tx_queues = 0; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-12-14 18:23:19.028385538 +0000 +++ 0028-net-i40e-remove-redundant-reset-of-queue-number.patch 2018-12-14 18:23:18.000000000 +0000 @@ -1,8 +1,10 @@ -From ef8b7c505f10897621c0801d8ef3e961385246f8 Mon Sep 17 00:00:00 2001 +From ae2b6e88781f2dba8f5e697d02d91ff1d59500d6 Mon Sep 17 00:00:00 2001 From: Zhirun Yan Date: Thu, 13 Dec 2018 12:49:28 +0000 Subject: [PATCH] net/i40e: remove redundant reset of queue number +[ upstream commit ef8b7c505f10897621c0801d8ef3e961385246f8 ] + Before this patch, there are two functions will call i40e_dev_free_queues to free queues. For rte_eth_dev_close(), its redundant because of duplication. For rte_eth_dev_reset() its @@ -12,7 +14,6 @@ This patch removes redundant code in i40e_dev_free_queues(). Fixes: 6b4537128394 ("i40e: free queue memory when closing") -Cc: stable@dpdk.org Signed-off-by: Zhirun Yan Signed-off-by: Haiyue Wang