patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] mk: fix scope of disabling AVX512F support
@ 2018-12-19 19:29 Ferruh Yigit
  2018-12-19 19:58 ` Thomas Monjalon
  2018-12-19 21:00 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
  0 siblings, 2 replies; 18+ messages in thread
From: Ferruh Yigit @ 2018-12-19 19:29 UTC (permalink / raw)
  To: dev, Thomas Monjalon
  Cc: Ferruh Yigit, stable, Tom Barbette, Yongseok Koh,
	Konstantin Ananyev, Bruce Richardson

AVX512 was disabled for GCC because of Bugzilla issue 97 [1],
the GCC defect submitted for the issue [2] highlighted that this is
a known binutils version 2.30 issue.

Narrowed the scope of no-avx512 to the this specific binutils version.

[1]
https://bugs.dpdk.org/show_bug.cgi?id=97

[2]
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88096

Fixes: 8d07c82b239f ("mk: disable gcc AVX512F support")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Tom Barbette <barbette@kth.se>
Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: Yongseok Koh <yskoh@mellanox.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
    We need similar check for meson which is missing right now.
---
 mk/rte.cpuflags.mk                       | 2 ++
 mk/toolchain/gcc/rte.toolchain-compat.mk | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
index c3291b17a..5e52e580d 100644
--- a/mk/rte.cpuflags.mk
+++ b/mk/rte.cpuflags.mk
@@ -71,10 +71,12 @@ CPUFLAGS += AVX512F
 else
 # disable AVX512F support of gcc as a workaround for Bug 97
 ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
+ifneq ($(filter 2.30%,$(LD_VERSION)),)
 MACHINE_CFLAGS += -mno-avx512f
 endif
 endif
 endif
+endif
 
 # IBM Power CPU flags
 ifneq ($(filter $(AUTO_CPUFLAGS),__PPC64__),)
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index 44904295c..2690aeb4d 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -20,6 +20,8 @@ HOST_GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(HOSTCC) -E -x c - | tail -n 1)
 HOST_GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(HOSTCC) -E -x c - | tail -n 1)
 HOST_GCC_VERSION = $(HOST_GCC_MAJOR)$(HOST_GCC_MINOR)
 
+LD_VERSION = $(shell ld -v)
+
 # if GCC is older than 4.x
 ifeq ($(shell test $(GCC_VERSION) -lt 40 && echo 1), 1)
 	MACHINE_CFLAGS =
-- 
2.17.2

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2019-01-14 16:29 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 19:29 [dpdk-stable] [PATCH] mk: fix scope of disabling AVX512F support Ferruh Yigit
2018-12-19 19:58 ` Thomas Monjalon
2018-12-19 20:20   ` Ferruh Yigit
2018-12-19 20:28     ` Thomas Monjalon
2018-12-19 20:53       ` Ferruh Yigit
2018-12-20 11:29         ` Bruce Richardson
2018-12-19 21:00 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2018-12-22 23:02   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-01-03 16:23   ` [dpdk-stable] [PATCH v3] " Ferruh Yigit
2019-01-03 22:46     ` Yongseok Koh
2019-01-04  2:40       ` Varghese, Vipin
2019-01-04 10:27         ` Ferruh Yigit
2019-01-04 10:28           ` Varghese, Vipin
2019-01-07 16:49     ` [dpdk-stable] [PATCH v4] " Ferruh Yigit
2019-01-08  3:50       ` Varghese, Vipin
2019-01-14 11:55       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-01-14 15:49       ` [dpdk-stable] [PATCH v5] " Ferruh Yigit
2019-01-14 16:28         ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).