From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 51CEC1B113 for ; Thu, 3 Jan 2019 09:14:52 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 3 Jan 2019 10:14:51 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x038EJfk008603; Thu, 3 Jan 2019 10:14:50 +0200 From: Yongseok Koh To: Andy Green Cc: Bruce Richardson , dpdk stable Date: Thu, 3 Jan 2019 00:13:40 -0800 Message-Id: <20190103081400.14191-17-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190103081400.14191-1-yskoh@mellanox.com> References: <20190103081400.14191-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'eal: explicit cast of strlcpy return' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 08:14:52 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 323afa8c5d4166c7591a4f6fad21535b2cede03d Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 22:03:48 +0800 Subject: [PATCH] eal: explicit cast of strlcpy return [ upstream commit 622a7305d1fd1e0150034b82ef92e62250befcd8 ] GCC 8.1 warns: rte_string_fns.h: In function 'rte_strlcpy': rte_string_fns.h:58:9: warning: conversion to 'size_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] return snprintf(dst, size, "%s", src); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 5d84a357fe57 ("eal: support strlcpy function") Signed-off-by: Andy Green Acked-by: Bruce Richardson --- lib/librte_eal/common/include/rte_string_fns.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_string_fns.h b/lib/librte_eal/common/include/rte_string_fns.h index 7c0ab15a3..7d57bb8ee 100644 --- a/lib/librte_eal/common/include/rte_string_fns.h +++ b/lib/librte_eal/common/include/rte_string_fns.h @@ -84,7 +84,7 @@ rte_strsplit(char *string, int stringlen, static inline size_t rte_strlcpy(char *dst, const char *src, size_t size) { - return snprintf(dst, size, "%s", src); + return (size_t)snprintf(dst, size, "%s", src); } /* pull in a strlcpy function */ -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-02 23:59:13.000160826 -0800 +++ 0017-eal-explicit-cast-of-strlcpy-return.patch 2019-01-02 23:59:12.059819000 -0800 @@ -1,8 +1,10 @@ -From 622a7305d1fd1e0150034b82ef92e62250befcd8 Mon Sep 17 00:00:00 2001 +From 323afa8c5d4166c7591a4f6fad21535b2cede03d Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 22:03:48 +0800 Subject: [PATCH] eal: explicit cast of strlcpy return +[ upstream commit 622a7305d1fd1e0150034b82ef92e62250befcd8 ] + GCC 8.1 warns: rte_string_fns.h: In function 'rte_strlcpy': rte_string_fns.h:58:9: @@ -11,7 +13,7 @@ return snprintf(dst, size, "%s", src); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Fixes: 5364de644a4b ("eal: support strlcpy function") +Fixes: 5d84a357fe57 ("eal: support strlcpy function") Signed-off-by: Andy Green Acked-by: Bruce Richardson @@ -20,10 +22,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_string_fns.h b/lib/librte_eal/common/include/rte_string_fns.h -index fcbb42e00..97597a148 100644 +index 7c0ab15a3..7d57bb8ee 100644 --- a/lib/librte_eal/common/include/rte_string_fns.h +++ b/lib/librte_eal/common/include/rte_string_fns.h -@@ -55,7 +55,7 @@ rte_strsplit(char *string, int stringlen, +@@ -84,7 +84,7 @@ rte_strsplit(char *string, int stringlen, static inline size_t rte_strlcpy(char *dst, const char *src, size_t size) {