From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id B8D071B130 for ; Thu, 3 Jan 2019 09:15:11 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 3 Jan 2019 10:15:08 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x038EJft008603; Thu, 3 Jan 2019 10:15:07 +0200 From: Yongseok Koh To: Andy Green Cc: Bruce Richardson , dpdk stable Date: Thu, 3 Jan 2019 00:13:49 -0800 Message-Id: <20190103081400.14191-26-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190103081400.14191-1-yskoh@mellanox.com> References: <20190103081400.14191-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net: explicit cast of multicast bit clearing' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 08:15:12 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 45f354944bcb9e5a670d74b416f867d8e431f1f9 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 21:49:47 +0800 Subject: [PATCH] net: explicit cast of multicast bit clearing [ upstream commit beb4076567441bb6f936f99f442c2a8de911bb3c ] GCC 8.1 warned: rte_ether.h:213:13: warning: conversion from 'int' to 'uint8_t' {aka 'unsigned char'} may change value [-Wconversion] addr[0] &= ~ETHER_GROUP_ADDR; Fixes: 7ef007291004 ("ethdev: random MAC address") Signed-off-by: Andy Green Acked-by: Bruce Richardson --- lib/librte_net/rte_ether.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 10d906e6f..f7a9a8695 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -239,7 +239,7 @@ static inline void eth_random_addr(uint8_t *addr) uint8_t *p = (uint8_t *)&rand; rte_memcpy(addr, p, ETHER_ADDR_LEN); - addr[0] &= ~ETHER_GROUP_ADDR; /* clear multicast bit */ + addr[0] &= (uint8_t)~ETHER_GROUP_ADDR; /* clear multicast bit */ addr[0] |= ETHER_LOCAL_ADMIN_ADDR; /* set local assignment bit */ } -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-02 23:59:13.466990483 -0800 +++ 0026-net-explicit-cast-of-multicast-bit-clearing.patch 2019-01-02 23:59:12.083819000 -0800 @@ -1,8 +1,10 @@ -From beb4076567441bb6f936f99f442c2a8de911bb3c Mon Sep 17 00:00:00 2001 +From 45f354944bcb9e5a670d74b416f867d8e431f1f9 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Thu, 17 May 2018 21:49:47 +0800 Subject: [PATCH] net: explicit cast of multicast bit clearing +[ upstream commit beb4076567441bb6f936f99f442c2a8de911bb3c ] + GCC 8.1 warned: rte_ether.h:213:13: @@ -11,7 +13,6 @@ addr[0] &= ~ETHER_GROUP_ADDR; Fixes: 7ef007291004 ("ethdev: random MAC address") -Cc: stable@dpdk.org Signed-off-by: Andy Green Acked-by: Bruce Richardson @@ -20,10 +21,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h -index 27c919594..bee2b34f0 100644 +index 10d906e6f..f7a9a8695 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h -@@ -210,7 +210,7 @@ static inline void eth_random_addr(uint8_t *addr) +@@ -239,7 +239,7 @@ static inline void eth_random_addr(uint8_t *addr) uint8_t *p = (uint8_t *)&rand; rte_memcpy(addr, p, ETHER_ADDR_LEN);