From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id D1AE31B129 for ; Thu, 3 Jan 2019 09:15:16 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 3 Jan 2019 10:15:13 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x038EJfw008603; Thu, 3 Jan 2019 10:15:12 +0200 From: Yongseok Koh To: Andy Green Cc: dpdk stable Date: Thu, 3 Jan 2019 00:13:52 -0800 Message-Id: <20190103081400.14191-29-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190103081400.14191-1-yskoh@mellanox.com> References: <20190103081400.14191-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'ethdev: explicit cast of queue count return' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 08:15:17 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 2cde5ec07db9287bb077ad2dfc2cc9820056fae2 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Fri, 18 May 2018 21:02:38 +0800 Subject: [PATCH] ethdev: explicit cast of queue count return [ upstream commit 45d1be93b9020dfe9c1f3e81822621580312dcc3 ] GCC 8.1 produces a warning: rte_ethdev.h: In function 'rte_eth_rx_queue_count': rte_ethdev.h:3882:10: warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'} may change the sign of the result [-Wsign-conversion] return (*dev->dev_ops->rx_queue_count)(dev, queue_id); ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 33cf6be04d60 ("ethdev: add sanity checks to functions") Signed-off-by: Andy Green --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index bbca590d4..65cb04755 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2935,7 +2935,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id) if (queue_id >= dev->data->nb_rx_queues) return -EINVAL; - return (*dev->dev_ops->rx_queue_count)(dev, queue_id); + return (int)(*dev->dev_ops->rx_queue_count)(dev, queue_id); } /** -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-02 23:59:13.620667292 -0800 +++ 0029-ethdev-explicit-cast-of-queue-count-return.patch 2019-01-02 23:59:12.091815000 -0800 @@ -1,8 +1,10 @@ -From 45d1be93b9020dfe9c1f3e81822621580312dcc3 Mon Sep 17 00:00:00 2001 +From 2cde5ec07db9287bb077ad2dfc2cc9820056fae2 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Fri, 18 May 2018 21:02:38 +0800 Subject: [PATCH] ethdev: explicit cast of queue count return +[ upstream commit 45d1be93b9020dfe9c1f3e81822621580312dcc3 ] + GCC 8.1 produces a warning: rte_ethdev.h: In function 'rte_eth_rx_queue_count': rte_ethdev.h:3882:10: warning: conversion to 'int' from 'uint32_t' @@ -11,18 +13,17 @@ ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 33cf6be04d60 ("ethdev: add sanity checks to functions") -Cc: stable@dpdk.org Signed-off-by: Andy Green --- - lib/librte_ethdev/rte_ethdev.h | 2 +- + lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h -index f8815e994..d52c1bed9 100644 ---- a/lib/librte_ethdev/rte_ethdev.h -+++ b/lib/librte_ethdev/rte_ethdev.h -@@ -3874,7 +3874,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id) +diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h +index bbca590d4..65cb04755 100644 +--- a/lib/librte_ether/rte_ethdev.h ++++ b/lib/librte_ether/rte_ethdev.h +@@ -2935,7 +2935,7 @@ rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id) if (queue_id >= dev->data->nb_rx_queues) return -EINVAL;