From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 2CA772BF4 for ; Thu, 3 Jan 2019 09:14:33 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 3 Jan 2019 10:14:31 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x038EJfZ008603; Thu, 3 Jan 2019 10:14:29 +0200 From: Yongseok Koh To: Andy Green Cc: Stephen Hemminger , dpdk stable Date: Thu, 3 Jan 2019 00:13:29 -0800 Message-Id: <20190103081400.14191-6-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190103081400.14191-1-yskoh@mellanox.com> References: <20190103081400.14191-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'ethdev: explicit cast of buffered Tx number' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 08:14:36 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/04/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 9279c2accec9ced9b2fb1c6a62263110ed904485 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 10:00:27 +0800 Subject: [PATCH] ethdev: explicit cast of buffered Tx number [ backported from upstream commit b90406b9f7340466cbda287cd7454fae68868348 ] In function 'rte_eth_tx_buffer_flush': rte_ethdev.h:4248:55: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] buffer->error_callback(&buffer->pkts[sent], to_send - sent, Fixes: d6c99e62c852 ("ethdev: add buffered Tx") Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index c4f68d1b9..bbca590d4 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -3361,8 +3361,9 @@ rte_eth_tx_buffer_flush(uint16_t port_id, uint16_t queue_id, /* All packets sent, or to be dealt with by callback below */ if (unlikely(sent != to_send)) - buffer->error_callback(&buffer->pkts[sent], to_send - sent, - buffer->error_userdata); + buffer->error_callback(&buffer->pkts[sent], + (uint16_t)(to_send - sent), + buffer->error_userdata); return sent; } -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-02 23:59:12.427744670 -0800 +++ 0006-ethdev-explicit-cast-of-buffered-Tx-number.patch 2019-01-02 23:59:12.018816000 -0800 @@ -1,8 +1,10 @@ -From b90406b9f7340466cbda287cd7454fae68868348 Mon Sep 17 00:00:00 2001 +From 9279c2accec9ced9b2fb1c6a62263110ed904485 Mon Sep 17 00:00:00 2001 From: Andy Green Date: Sat, 12 May 2018 10:00:27 +0800 Subject: [PATCH] ethdev: explicit cast of buffered Tx number +[ backported from upstream commit b90406b9f7340466cbda287cd7454fae68868348 ] + In function 'rte_eth_tx_buffer_flush': rte_ethdev.h:4248:55: warning: conversion from 'int' to 'uint16_t' @@ -10,19 +12,18 @@ buffer->error_callback(&buffer->pkts[sent], to_send - sent, Fixes: d6c99e62c852 ("ethdev: add buffered Tx") -Cc: stable@dpdk.org Signed-off-by: Andy Green Reviewed-by: Stephen Hemminger --- - lib/librte_ethdev/rte_ethdev.h | 5 +++-- + lib/librte_ether/rte_ethdev.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h -index 7ccf4bae6..49c2ebbd5 100644 ---- a/lib/librte_ethdev/rte_ethdev.h -+++ b/lib/librte_ethdev/rte_ethdev.h -@@ -4240,8 +4240,9 @@ rte_eth_tx_buffer_flush(uint16_t port_id, uint16_t queue_id, +diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h +index c4f68d1b9..bbca590d4 100644 +--- a/lib/librte_ether/rte_ethdev.h ++++ b/lib/librte_ether/rte_ethdev.h +@@ -3361,8 +3361,9 @@ rte_eth_tx_buffer_flush(uint16_t port_id, uint16_t queue_id, /* All packets sent, or to be dealt with by callback below */ if (unlikely(sent != to_send))