From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 00A3F1B49F for ; Fri, 4 Jan 2019 14:26:36 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 637D33DBEC; Fri, 4 Jan 2019 13:26:35 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-13.ams2.redhat.com [10.36.117.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id C34855C22F; Fri, 4 Jan 2019 13:26:33 +0000 (UTC) From: Kevin Traynor To: Erik Gabriel Carrillo Cc: Jerin Jacob , dpdk stable Date: Fri, 4 Jan 2019 13:23:55 +0000 Message-Id: <20190104132455.15170-13-ktraynor@redhat.com> In-Reply-To: <20190104132455.15170-1-ktraynor@redhat.com> References: <20190104132455.15170-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 04 Jan 2019 13:26:35 +0000 (UTC) Subject: [dpdk-stable] patch 'app/eventdev: detect deadlock for timer event producer' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 13:26:36 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/11/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From d581ef04bbd88ae93b57c2a340036700d27fdbaa Mon Sep 17 00:00:00 2001 From: Erik Gabriel Carrillo Date: Mon, 3 Dec 2018 11:48:14 -0600 Subject: [PATCH] app/eventdev: detect deadlock for timer event producer [ upstream commit 4730378428cf32a8ccdf6c018a399536a7144cc6 ] If timer events get dropped for some reason, the thread that launched producer and worker cores will never exit, because the deadlock check doesn't currently apply to the event timer adapter case. This commit fixes this. Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer") Signed-off-by: Erik Gabriel Carrillo Acked-by: Jerin Jacob --- app/test-eventdev/test_perf_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c index 861877532..f99a6a607 100644 --- a/app/test-eventdev/test_perf_common.c +++ b/app/test-eventdev/test_perf_common.c @@ -328,5 +328,6 @@ perf_launch_lcores(struct evt_test *test, struct evt_options *opt, if (new_cycles - dead_lock_cycles > dead_lock_sample && - opt->prod_type == EVT_PROD_TYPE_SYNT) { + (opt->prod_type == EVT_PROD_TYPE_SYNT || + opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) { remaining = t->outstand_pkts - processed_pkts(t); if (dead_lock_remaining == remaining) { -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-04 13:23:07.768311296 +0000 +++ 0013-app-eventdev-detect-deadlock-for-timer-event-produce.patch 2019-01-04 13:23:07.000000000 +0000 @@ -1,15 +1,16 @@ -From 4730378428cf32a8ccdf6c018a399536a7144cc6 Mon Sep 17 00:00:00 2001 +From d581ef04bbd88ae93b57c2a340036700d27fdbaa Mon Sep 17 00:00:00 2001 From: Erik Gabriel Carrillo Date: Mon, 3 Dec 2018 11:48:14 -0600 Subject: [PATCH] app/eventdev: detect deadlock for timer event producer +[ upstream commit 4730378428cf32a8ccdf6c018a399536a7144cc6 ] + If timer events get dropped for some reason, the thread that launched producer and worker cores will never exit, because the deadlock check doesn't currently apply to the event timer adapter case. This commit fixes this. Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer") -Cc: stable@dpdk.org Signed-off-by: Erik Gabriel Carrillo Acked-by: Jerin Jacob