From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DEC661B494 for ; Fri, 4 Jan 2019 14:26:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 496C286675; Fri, 4 Jan 2019 13:26:52 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-13.ams2.redhat.com [10.36.117.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCFD15C224; Fri, 4 Jan 2019 13:26:50 +0000 (UTC) From: Kevin Traynor To: Tomasz Jozwiak Cc: Fiona Trahe , dpdk stable Date: Fri, 4 Jan 2019 13:24:03 +0000 Message-Id: <20190104132455.15170-21-ktraynor@redhat.com> In-Reply-To: <20190104132455.15170-1-ktraynor@redhat.com> References: <20190104132455.15170-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 04 Jan 2019 13:26:52 +0000 (UTC) Subject: [dpdk-stable] patch 'common/qat: remove check of valid firmware response' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 13:26:53 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/11/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From aba3a2b8920464eb98fd8f617b3dee4e02a1fa13 Mon Sep 17 00:00:00 2001 From: Tomasz Jozwiak Date: Fri, 14 Dec 2018 12:19:30 +0100 Subject: [PATCH] common/qat: remove check of valid firmware response [ upstream commit 8c41455e9e610385b826271798c0b532fd59054a ] This reverts commit d09973f6c4df ("common/qat: fix for invalid response from firmware") due to incorrectly reporting failures on some older firmware versions. Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware") Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c index 79f6a01ba..ec7f2b309 100644 --- a/drivers/common/qat/qat_qp.c +++ b/drivers/common/qat/qat_qp.c @@ -635,5 +635,4 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops) uint32_t resp_counter = 0; uint8_t *resp_msg; - uint8_t hdr_flags; rx_queue = &(tmp_qp->rx_q); @@ -641,15 +640,8 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops) head = rx_queue->head; resp_msg = (uint8_t *)rx_queue->base_addr + rx_queue->head; - hdr_flags = ((struct icp_qat_fw_comn_resp_hdr *)resp_msg)->hdr_flags; while (*(uint32_t *)resp_msg != ADF_RING_EMPTY_SIG && resp_counter != nb_ops) { - if (unlikely(!ICP_QAT_FW_COMN_VALID_FLAG_GET(hdr_flags))) { - /* Fatal firmware error */ - QAT_LOG(ERR, "QAT Firmware returned invalid response"); - return 0; - } - if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC) qat_sym_process_response(ops, resp_msg); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-04 13:23:07.958286953 +0000 +++ 0021-common-qat-remove-check-of-valid-firmware-response.patch 2019-01-04 13:23:07.000000000 +0000 @@ -1,14 +1,15 @@ -From 8c41455e9e610385b826271798c0b532fd59054a Mon Sep 17 00:00:00 2001 +From aba3a2b8920464eb98fd8f617b3dee4e02a1fa13 Mon Sep 17 00:00:00 2001 From: Tomasz Jozwiak Date: Fri, 14 Dec 2018 12:19:30 +0100 Subject: [PATCH] common/qat: remove check of valid firmware response +[ upstream commit 8c41455e9e610385b826271798c0b532fd59054a ] + This reverts commit d09973f6c4df ("common/qat: fix for invalid response from firmware") due to incorrectly reporting failures on some older firmware versions. Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware") -Cc: stable@dpdk.org Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe