From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1B91F1B48B for ; Fri, 4 Jan 2019 14:26:55 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7080586673; Fri, 4 Jan 2019 13:26:54 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-13.ams2.redhat.com [10.36.117.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5F175C1A1; Fri, 4 Jan 2019 13:26:52 +0000 (UTC) From: Kevin Traynor To: Tomasz Jozwiak Cc: Fiona Trahe , dpdk stable Date: Fri, 4 Jan 2019 13:24:04 +0000 Message-Id: <20190104132455.15170-22-ktraynor@redhat.com> In-Reply-To: <20190104132455.15170-1-ktraynor@redhat.com> References: <20190104132455.15170-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 04 Jan 2019 13:26:54 +0000 (UTC) Subject: [dpdk-stable] patch 'compress/qat: fix return on building request error' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 13:26:55 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/11/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 5d50bb019b0010f472c8a9c07338705f9b31f1ac Mon Sep 17 00:00:00 2001 From: Tomasz Jozwiak Date: Fri, 14 Dec 2018 12:19:31 +0100 Subject: [PATCH] compress/qat: fix return on building request error [ upstream commit 652b59df06ccf554d4c39ab76f8b85cc003cf9b0 ] This patch fixes error status which should be set inside qat_comp_build_request function in case any errors are detected. In these cases op.status is set to RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug. Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers") Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- drivers/compress/qat/qat_comp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 27547428f..8a6fad06a 100644 --- a/drivers/compress/qat/qat_comp.c +++ b/drivers/compress/qat/qat_comp.c @@ -37,4 +37,5 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg, "operation requests, op (%p) is not a " "stateless operation.", op); + op->status = RTE_COMP_OP_STATUS_INVALID_ARGS; return -EINVAL; } @@ -62,4 +63,5 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg, if (ret) { QAT_DP_LOG(ERR, "QAT PMD Cannot fill source sgl array"); + op->status = RTE_COMP_OP_STATUS_INVALID_ARGS; return ret; } @@ -72,4 +74,5 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg, if (ret) { QAT_DP_LOG(ERR, "QAT PMD Cannot fill dest. sgl array"); + op->status = RTE_COMP_OP_STATUS_INVALID_ARGS; return ret; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-04 13:23:07.980659179 +0000 +++ 0022-compress-qat-fix-return-on-building-request-error.patch 2019-01-04 13:23:07.000000000 +0000 @@ -1,15 +1,16 @@ -From 652b59df06ccf554d4c39ab76f8b85cc003cf9b0 Mon Sep 17 00:00:00 2001 +From 5d50bb019b0010f472c8a9c07338705f9b31f1ac Mon Sep 17 00:00:00 2001 From: Tomasz Jozwiak Date: Fri, 14 Dec 2018 12:19:31 +0100 Subject: [PATCH] compress/qat: fix return on building request error +[ upstream commit 652b59df06ccf554d4c39ab76f8b85cc003cf9b0 ] + This patch fixes error status which should be set inside qat_comp_build_request function in case any errors are detected. In these cases op.status is set to RTE_COMP_OP_STATUS_INVALID_ARGS to help application debug. Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers") -Cc: stable@dpdk.org Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe