From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A188F1B489 for ; Fri, 4 Jan 2019 14:28:07 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D7ED88306; Fri, 4 Jan 2019 13:28:07 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-13.ams2.redhat.com [10.36.117.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 871495C1A1; Fri, 4 Jan 2019 13:28:05 +0000 (UTC) From: Kevin Traynor To: Rafal Kozik Cc: Michal Krawczyk , dpdk stable Date: Fri, 4 Jan 2019 13:24:37 +0000 Message-Id: <20190104132455.15170-55-ktraynor@redhat.com> In-Reply-To: <20190104132455.15170-1-ktraynor@redhat.com> References: <20190104132455.15170-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 04 Jan 2019 13:28:07 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ena: fix invalid reference to variable in union' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 13:28:08 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/11/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From ce4014623d0df375dec16bc490090e77574263d8 Mon Sep 17 00:00:00 2001 From: Rafal Kozik Date: Fri, 14 Dec 2018 14:18:39 +0100 Subject: [PATCH] net/ena: fix invalid reference to variable in union [ upstream commit eccbe2ffdc755a9e759c6ba480f6c15ccb1163c7 ] Use empty_rx_reqs instead of empty_tx_reqs. As those two variables are part of union this not cause any failure, but for consistency should be changed. Fixes: c2034976673d ("net/ena: add Rx out of order completion") Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 4a9b1eebf..e8db81a38 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1324,5 +1324,5 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev, for (i = 0; i < nb_desc; i++) - rxq->empty_tx_reqs[i] = i; + rxq->empty_rx_reqs[i] = i; /* Store pointer to this queue in upper layer */ -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-04 13:23:08.787078059 +0000 +++ 0055-net-ena-fix-invalid-reference-to-variable-in-union.patch 2019-01-04 13:23:07.000000000 +0000 @@ -1,14 +1,15 @@ -From eccbe2ffdc755a9e759c6ba480f6c15ccb1163c7 Mon Sep 17 00:00:00 2001 +From ce4014623d0df375dec16bc490090e77574263d8 Mon Sep 17 00:00:00 2001 From: Rafal Kozik Date: Fri, 14 Dec 2018 14:18:39 +0100 Subject: [PATCH] net/ena: fix invalid reference to variable in union +[ upstream commit eccbe2ffdc755a9e759c6ba480f6c15ccb1163c7 ] + Use empty_rx_reqs instead of empty_tx_reqs. As those two variables are part of union this not cause any failure, but for consistency should be changed. Fixes: c2034976673d ("net/ena: add Rx out of order completion") -Cc: stable@dpdk.org Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk @@ -17,10 +18,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c -index 3aa32a3bf..14165561e 100644 +index 4a9b1eebf..e8db81a38 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c -@@ -1388,5 +1388,5 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev, +@@ -1324,5 +1324,5 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev, for (i = 0; i < nb_desc; i++) - rxq->empty_tx_reqs[i] = i;