From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B1C1B1B490 for ; Fri, 4 Jan 2019 14:28:24 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E949658E27; Fri, 4 Jan 2019 13:28:23 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-13.ams2.redhat.com [10.36.117.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B4155C1A1; Fri, 4 Jan 2019 13:28:22 +0000 (UTC) From: Kevin Traynor To: Hideyuki Yamashita Cc: Yasufumi Ogawa , Tiwei Bie , dpdk stable Date: Fri, 4 Jan 2019 13:24:46 +0000 Message-Id: <20190104132455.15170-64-ktraynor@redhat.com> In-Reply-To: <20190104132455.15170-1-ktraynor@redhat.com> References: <20190104132455.15170-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 04 Jan 2019 13:28:24 +0000 (UTC) Subject: [dpdk-stable] patch 'net/vhost: fix double free of MAC address' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 13:28:25 -0000 Hi, FYI, your patch has been queued to LTS release 18.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 01/11/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Kevin Traynor --- >>From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001 From: Hideyuki Yamashita Date: Wed, 19 Dec 2018 13:37:18 +0900 Subject: [PATCH] net/vhost: fix double free of MAC address [ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ] The common data freeing has been moved to rte_eth_dev_release_port(), so freeing mac_addrs like this in eth_dev_close() is unnecessary and will cause double free. Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") Signed-off-by: Hideyuki Yamashita Signed-off-by: Yasufumi Ogawa Reviewed-by: Tiwei Bie --- drivers/net/vhost/rte_eth_vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 42bdfcbd5..b2cda0483 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1001,5 +1001,4 @@ eth_dev_close(struct rte_eth_dev *dev) rte_free(dev->data->tx_queues[i]); - rte_free(dev->data->mac_addrs); free(internal->dev_name); free(internal->iface_name); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-01-04 13:23:09.004712018 +0000 +++ 0064-net-vhost-fix-double-free-of-MAC-address.patch 2019-01-04 13:23:07.000000000 +0000 @@ -1,14 +1,15 @@ -From 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 Mon Sep 17 00:00:00 2001 +From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001 From: Hideyuki Yamashita Date: Wed, 19 Dec 2018 13:37:18 +0900 Subject: [PATCH] net/vhost: fix double free of MAC address +[ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ] + The common data freeing has been moved to rte_eth_dev_release_port(), so freeing mac_addrs like this in eth_dev_close() is unnecessary and will cause double free. Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") -Cc: stable@dpdk.org Signed-off-by: Hideyuki Yamashita Signed-off-by: Yasufumi Ogawa