From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.ics.ntt-tx.co.jp (mail05.ics.ntt-tx.co.jp [210.232.35.69]) by dpdk.org (Postfix) with ESMTP id 2ECA51B1F4 for ; Wed, 9 Jan 2019 08:41:47 +0100 (CET) Received: from gwchk03.silk.ntt-tx.co.jp (gwchk03.silk.ntt-tx.co.jp [10.107.0.111]) by mail04.ics.ntt-tx.co.jp (unknown) with ESMTP id x097fjKL023453; Wed, 9 Jan 2019 16:41:46 +0900 Received: (from root@localhost) by gwchk03.silk.ntt-tx.co.jp (unknown) id x097fjoH006357; Wed, 9 Jan 2019 16:41:45 +0900 Received: from gwchk.silk.ntt-tx.co.jp [10.107.0.110] by gwchk03.silk.ntt-tx.co.jp with ESMTP id SAA06356; Wed, 9 Jan 2019 16:41:45 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by ccmail04.silk.ntt-tx.co.jp (unknown) with ESMTP id x097fjwf030605; Wed, 9 Jan 2019 16:41:45 +0900 Received: from imss06.silk.ntt-tx.co.jp (localhost [127.0.0.1]) by imss06.silk.ntt-tx.co.jp (unknown) with ESMTP id x097fjX2004584; Wed, 9 Jan 2019 16:41:45 +0900 Received: from ccmail04 (smtp03.silk.ntt-tx.co.jp [10.107.0.135]) by imss06.silk.ntt-tx.co.jp (unknown) with SMTP id x097fjQB004581; Wed, 9 Jan 2019 16:41:45 +0900 Date: Wed, 09 Jan 2019 16:39:22 +0900 From: Hideyuki Yamashita In-Reply-To: <5b0a23d0-5e58-c77e-507b-4209bef6bb58@redhat.com> References: <201901070006.x0706IxZ018889@ccmail04.silk.ntt-tx.co.jp> <5b0a23d0-5e58-c77e-507b-4209bef6bb58@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.74 [ja] X-CCMail7: CC-Mail-V7.0.2-Client-Relayed Message-Id: <201901090741.x097fGGW030401@ccmail04.silk.ntt-tx.co.jp> X-TM-AS-MML: No X-CC-Mail-RelayStamp: CC-Mail-V5.14-Server To: Kevin Traynor Cc: Yasufumi Ogawa , Tiwei Bie , dpdk stable Subject: Re: [dpdk-stable] patch 'net/vhost: fix double free of MAC address' has been queued to LTS release 18.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 07:41:48 -0000 Hello Kevin, Thanks for your answering. Basic questions to ask. Q1. When 18.11.1 will be released? 11st January? Q2. Let us assume that I submit another patch to dev@dpdk.org CCed stable@dpdk.org. Target stable release version is 18.11.2? If yes, when the above release will be available? Where can I get such a schedule? Note that so far I did not subscribe to stable mailing list. (I just subscribed that) Thanks! BR, Hideyuki Yamashita NTT TechnoCross > On 01/07/2019 12:04 AM, Hideyuki Yamashita wrote: > > Hello Kevin, > > > > Hi Hideyuki, > > > Thanks for your answering me. > > > > I understand that now my patch is queued to LTS 18.11.1. > > > > I would like to ask general rules which kind of patch is queued > > to LTS and which is not. > > (If I CCed stable@dpdk.org when I submmit patch, it is automatically > > queued? If that is true then how (or where) can I watch the status > > of my patch?) > > > > In short yes with 'Cc: stable@dpdk.org' tag, and a relevant 'Fixes:..' > tag. See fuller answer here: > http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported > > Status is through emails like this one, and a summary email before > release. e.g for 18.08 > https://mails.dpdk.org/archives/stable/2018-December/011828.html > > Kevin. > > > The reason why I ask this is that from user perspective > > I want as much patches be queued to LTS so that we can > > use LTS as stable one. > > > > Yes, I agree :-) > > > Thanks! > > > > BR, > > Hideyuki Yamashita > > NTT TechnoCross > > > >> Hi, > >> > >> FYI, your patch has been queued to LTS release 18.11.1 > >> > >> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > >> It will be pushed if I get no objections before 01/11/19. So please > >> shout if anyone has objections. > >> > >> Also note that after the patch there's a diff of the upstream commit vs the > >> patch applied to the branch. This will indicate if there was any rebasing > >> needed to apply to the stable branch. If there were code changes for rebasing > >> (ie: not only metadata diffs), please double check that the rebase was > >> correctly done. > >> > >> Thanks. > >> > >> Kevin Traynor > >> > >> --- > >> From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001 > >> From: Hideyuki Yamashita > >> Date: Wed, 19 Dec 2018 13:37:18 +0900 > >> Subject: [PATCH] net/vhost: fix double free of MAC address > >> > >> [ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ] > >> > >> The common data freeing has been moved to rte_eth_dev_release_port(), > >> so freeing mac_addrs like this in eth_dev_close() is unnecessary and > >> will cause double free. > >> > >> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") > >> > >> Signed-off-by: Hideyuki Yamashita > >> Signed-off-by: Yasufumi Ogawa > >> Reviewed-by: Tiwei Bie > >> --- > >> drivers/net/vhost/rte_eth_vhost.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > >> index 42bdfcbd5..b2cda0483 100644 > >> --- a/drivers/net/vhost/rte_eth_vhost.c > >> +++ b/drivers/net/vhost/rte_eth_vhost.c > >> @@ -1001,5 +1001,4 @@ eth_dev_close(struct rte_eth_dev *dev) > >> rte_free(dev->data->tx_queues[i]); > >> > >> - rte_free(dev->data->mac_addrs); > >> free(internal->dev_name); > >> free(internal->iface_name); > >> -- > >> 2.19.0 > >> > >> --- > >> Diff of the applied patch vs upstream commit (please double-check if non-empty: > >> --- > >> --- - 2019-01-04 13:23:09.004712018 +0000 > >> +++ 0064-net-vhost-fix-double-free-of-MAC-address.patch 2019-01-04 13:23:07.000000000 +0000 > >> @@ -1,14 +1,15 @@ > >> -From 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 Mon Sep 17 00:00:00 2001 > >> +From 00ffa031bda23be8e1d558d8ed981389628bc543 Mon Sep 17 00:00:00 2001 > >> From: Hideyuki Yamashita > >> Date: Wed, 19 Dec 2018 13:37:18 +0900 > >> Subject: [PATCH] net/vhost: fix double free of MAC address > >> > >> +[ upstream commit 6e3339ca07734e59cd0c24594e3014ab49a0ffc0 ] > >> + > >> The common data freeing has been moved to rte_eth_dev_release_port(), > >> so freeing mac_addrs like this in eth_dev_close() is unnecessary and > >> will cause double free. > >> > >> Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") > >> -Cc: stable@dpdk.org > >> > >> Signed-off-by: Hideyuki Yamashita > >> Signed-off-by: Yasufumi Ogawa > > > >