From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 241AE1B938;
Fri, 11 Jan 2019 10:57:37 +0100 (CET)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
11 Jan 2019 01:57:37 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,465,1539673200"; d="scan'208";a="115972607"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.54])
by fmsmga008.fm.intel.com with SMTP; 11 Jan 2019 01:57:34 -0800
Received: by (sSMTP sendmail emulation); Fri, 11 Jan 2019 09:57:33 +0000
Date: Fri, 11 Jan 2019 09:57:33 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
Cc: Luca Boccassi <bluca@debian.org>, "dev@dpdk.org" <dev@dpdk.org>,
"christian.ehrhardt@canonical.com" <christian.ehrhardt@canonical.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Message-ID: <20190111095732.GA21328@bricha3-MOBL.ger.corp.intel.com>
References: <20190110172806.12952-1-bluca@debian.org>
<VI1PR08MB31672167AC760DC920DE714E8F850@VI1PR08MB3167.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR08MB31672167AC760DC920DE714E8F850@VI1PR08MB3167.eurprd08.prod.outlook.com>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] build: mention -march in
pkg-config description
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jan 2019 09:57:38 -0000
On Fri, Jan 11, 2019 at 03:58:46AM +0000, Gavin Hu (Arm Technology China) wrote:
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > Sent: Friday, January 11, 2019 1:28 AM
> > To: dev@dpdk.org
> > Cc: bruce.richardson@intel.com; christian.ehrhardt@canonical.com; Luca
> > Boccassi <bluca@debian.org>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config description
> >
> > Applications need to at least match DPDK's -march option to build
> > successfully due to some static inline functions in the public headers.
> >
> > This might cause problems, especially in distributions, so add a note
> > in the pkg-config description.
> >
> > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > At the moment there are no adversely affected applications in Debian and
> > Ubuntu (collectd builds a separate shared object, and OVS/virtio-forwareder
> > are stand-alone DPDK-specific binaries), but we thought that having an
> > explicit notice would be good.
> >
> > meson.build | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index f87dc235f..35126106a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -83,7 +83,9 @@ pkg.generate(name: meson.project_name(),
> > libraries: dpdk_libraries,
> > libraries_private: dpdk_drivers + dpdk_static_libraries +
> > ['-Wl,-Bdynamic'] + dpdk_extra_ldflags,
> > -description: 'The Data Plane Development Kit (DPDK)',
> > +description: '''The Data Plane Development Kit (DPDK).
> > +Note that CFLAGS might contain an -march flag higher than typical baseline.
> > +This is required for a number of static inline functions in the public
> From Arm's perspective, this notice is really necessary for some extensions like LSE to work for performance.
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>
No objection from me for more documentation.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>