From: Yongseok Koh <yskoh@mellanox.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'app/testpmd: fix memory leak for TM object' has been queued to LTS release 17.11.5
Date: Fri, 11 Jan 2019 02:31:38 -0800 [thread overview]
Message-ID: <20190111103142.21088-15-yskoh@mellanox.com> (raw)
In-Reply-To: <20190111103142.21088-1-yskoh@mellanox.com>
Hi,
FYI, your patch has been queued to LTS release 17.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/13/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Yongseok
---
>From ee97d28d8f493007bd555d9056ea1a3ec59ddb94 Mon Sep 17 00:00:00 2001
From: Jasvinder Singh <jasvinder.singh@intel.com>
Date: Tue, 6 Nov 2018 10:23:06 +0000
Subject: [PATCH] app/testpmd: fix memory leak for TM object
[ upstream commit 8bf02b320e27ec27af12d345663f557b04a4c677 ]
Fixes memory leak for shared shaper object of the traffic manager.
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
app/test-pmd/tm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/tm.c b/app/test-pmd/tm.c
index dd837cb8c..d3ba86505 100644
--- a/app/test-pmd/tm.c
+++ b/app/test-pmd/tm.c
@@ -616,6 +616,7 @@ softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h,
error->message,
shaper_profile_id);
+ free(tnp.shared_shaper_id);
return -1;
}
tnp.shaper_profile_id = shaper_profile_id;
@@ -631,6 +632,7 @@ softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h,
error->message,
h->tc_node_id[pos][k]);
+ free(tnp.shared_shaper_id);
return -1;
}
shaper_profile_id++;
--
2.11.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-01-11 02:29:11.704900726 -0800
+++ 0015-app-testpmd-fix-memory-leak-for-TM-object.patch 2019-01-11 02:29:10.797973000 -0800
@@ -1,24 +1,25 @@
-From 8bf02b320e27ec27af12d345663f557b04a4c677 Mon Sep 17 00:00:00 2001
+From ee97d28d8f493007bd555d9056ea1a3ec59ddb94 Mon Sep 17 00:00:00 2001
From: Jasvinder Singh <jasvinder.singh@intel.com>
Date: Tue, 6 Nov 2018 10:23:06 +0000
Subject: [PATCH] app/testpmd: fix memory leak for TM object
+[ upstream commit 8bf02b320e27ec27af12d345663f557b04a4c677 ]
+
Fixes memory leak for shared shaper object of the traffic manager.
Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode")
-Cc: stable@dpdk.org
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
- app/test-pmd/softnicfwd.c | 2 ++
+ app/test-pmd/tm.c | 2 ++
1 file changed, 2 insertions(+)
-diff --git a/app/test-pmd/softnicfwd.c b/app/test-pmd/softnicfwd.c
-index 7ff622806..94e6669d3 100644
---- a/app/test-pmd/softnicfwd.c
-+++ b/app/test-pmd/softnicfwd.c
-@@ -458,6 +458,7 @@ softport_tm_tc_node_add(portid_t port_id,
+diff --git a/app/test-pmd/tm.c b/app/test-pmd/tm.c
+index dd837cb8c..d3ba86505 100644
+--- a/app/test-pmd/tm.c
++++ b/app/test-pmd/tm.c
+@@ -616,6 +616,7 @@ softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h,
error->message,
shaper_profile_id);
@@ -26,7 +27,7 @@
return -1;
}
tnp.shaper_profile_id = shaper_profile_id;
-@@ -473,6 +474,7 @@ softport_tm_tc_node_add(portid_t port_id,
+@@ -631,6 +632,7 @@ softport_tm_tc_node_add(portid_t port_id, struct tm_hierarchy *h,
error->message,
h->tc_node_id[pos][k]);
next prev parent reply other threads:[~2019-01-11 10:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 10:31 [dpdk-stable] patch 'net/octeontx: fix packet corruption on Tx' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'doc: fix style and syntax in flow API guide' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'net/mvpp2: fix array initialization' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'net/mlx5: fix interrupt completion queue index wrapping' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'doc: fix missing CCM to QAT feature list' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'app/testpmd: check Rx VLAN offload flag to print VLAN TCI' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'doc: fix typos in the flow API guide' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'app/testpmd: fix metering and policing commands' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'net/virtio: fix PCI config error handling' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'bus/dpaa: fix build with gcc 9.0' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'app/testpmd: fix RED byte stats' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'examples/flow_filtering: remove VLAN item' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'net/virtio: fix unchecked return value' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'net/octeontx: fix mbuf corruption with large private sizes' " Yongseok Koh
2019-01-11 10:31 ` Yongseok Koh [this message]
2019-01-11 10:31 ` [dpdk-stable] patch 'net/octeontx: fix failures when available ports > queues' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'app/pdump: fix port id storage size' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'doc: add cross-compilation in sample apps guide' " Yongseok Koh
2019-01-11 10:31 ` [dpdk-stable] patch 'net/mlx4: fix possible uninitialized variable' " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111103142.21088-15-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).