patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] eal: fix clang build with intrinsics forced
       [not found] <CGME20190115112946eucas1p22fa0b405d8cfe1feae7426a9b37857b1@eucas1p2.samsung.com>
@ 2019-01-15 11:29 ` Ilya Maximets
  2019-01-17 16:54   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Ilya Maximets @ 2019-01-15 11:29 UTC (permalink / raw)
  To: dev, Thomas Monjalon
  Cc: Pavan Nikhilesh, Bruce Richardson, Honnappa Nagarahalli,
	Ilya Maximets, stable

This fixes x86_64-native-linuxapp-clang build with
CONFIG_RTE_FORCE_INTRINSICS=y:

    include/generic/rte_atomic.h:218:9: error:
        implicit declaration of function '__atomic_exchange_2'
        is invalid in C99 [-Werror,-Wimplicit-function-declaration]

    include/generic/rte_atomic.h:501:9: error:
        implicit declaration of function '__atomic_exchange_4'
        is invalid in C99 [-Werror,-Wimplicit-function-declaration]

    include/generic/rte_atomic.h:783:9: error:
        implicit declaration of function '__atomic_exchange_8'
        is invalid in C99 [-Werror,-Wimplicit-function-declaration]

We didn't caught this issue previously on other platforms because
CONFIG_RTE_FORCE_INTRINSICS enabled by default only for armv8.

Fixes: 7bdccb93078e ("eal: fix ARM build with clang")
Cc: stable@dpdk.org

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 lib/librte_eal/common/include/generic/rte_atomic.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/include/generic/rte_atomic.h b/lib/librte_eal/common/include/generic/rte_atomic.h
index d0c464fb1..4afd1acc3 100644
--- a/lib/librte_eal/common/include/generic/rte_atomic.h
+++ b/lib/librte_eal/common/include/generic/rte_atomic.h
@@ -212,7 +212,7 @@ rte_atomic16_exchange(volatile uint16_t *dst, uint16_t val);
 static inline uint16_t
 rte_atomic16_exchange(volatile uint16_t *dst, uint16_t val)
 {
-#if defined(RTE_ARCH_ARM64) && defined(__clang__)
+#if defined(__clang__)
 	return __atomic_exchange_n(dst, val, __ATOMIC_SEQ_CST);
 #else
 	return __atomic_exchange_2(dst, val, __ATOMIC_SEQ_CST);
@@ -495,7 +495,7 @@ rte_atomic32_exchange(volatile uint32_t *dst, uint32_t val);
 static inline uint32_t
 rte_atomic32_exchange(volatile uint32_t *dst, uint32_t val)
 {
-#if defined(RTE_ARCH_ARM64) && defined(__clang__)
+#if defined(__clang__)
 	return __atomic_exchange_n(dst, val, __ATOMIC_SEQ_CST);
 #else
 	return __atomic_exchange_4(dst, val, __ATOMIC_SEQ_CST);
@@ -777,7 +777,7 @@ rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val);
 static inline uint64_t
 rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
 {
-#if defined(RTE_ARCH_ARM64) && defined(__clang__)
+#if defined(__clang__)
 	return __atomic_exchange_n(dst, val, __ATOMIC_SEQ_CST);
 #else
 	return __atomic_exchange_8(dst, val, __ATOMIC_SEQ_CST);
-- 
2.17.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix clang build with intrinsics forced
  2019-01-15 11:29 ` [dpdk-stable] [PATCH] eal: fix clang build with intrinsics forced Ilya Maximets
@ 2019-01-17 16:54   ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-01-17 16:54 UTC (permalink / raw)
  To: Ilya Maximets
  Cc: dev, Pavan Nikhilesh, Bruce Richardson, Honnappa Nagarahalli, stable

15/01/2019 12:29, Ilya Maximets:
> This fixes x86_64-native-linuxapp-clang build with
> CONFIG_RTE_FORCE_INTRINSICS=y:
> 
>     include/generic/rte_atomic.h:218:9: error:
>         implicit declaration of function '__atomic_exchange_2'
>         is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
>     include/generic/rte_atomic.h:501:9: error:
>         implicit declaration of function '__atomic_exchange_4'
>         is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
>     include/generic/rte_atomic.h:783:9: error:
>         implicit declaration of function '__atomic_exchange_8'
>         is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
> We didn't caught this issue previously on other platforms because
> CONFIG_RTE_FORCE_INTRINSICS enabled by default only for armv8.
> 
> Fixes: 7bdccb93078e ("eal: fix ARM build with clang")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-17 16:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20190115112946eucas1p22fa0b405d8cfe1feae7426a9b37857b1@eucas1p2.samsung.com>
2019-01-15 11:29 ` [dpdk-stable] [PATCH] eal: fix clang build with intrinsics forced Ilya Maximets
2019-01-17 16:54   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).