From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30074.outbound.protection.outlook.com [40.107.3.74]) by dpdk.org (Postfix) with ESMTP id 456492BDB for ; Tue, 22 Jan 2019 15:51:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNkxiJlBIP7eqB5ApU83etS3yY0iRPi+c2nKjTDyx+w=; b=RcxjoWRnTRgvo1SkJqk4V9NwoiT++IxhD3cAjvOr+B20fTWFu0cKGBYBE5Bztfq9kQo/7/ABQMA3EnO+PLAN7pED4JFwLhJaHxc4eaXYX8DVLPBdb5vdw1ooK1Tv17/204U3ioE0cK5CpnfGf1xvOLOMyzXro4biWYqndHG/VFI= Received: from VI1PR05MB4269.eurprd05.prod.outlook.com (52.133.12.22) by VI1PR05MB4719.eurprd05.prod.outlook.com (20.176.4.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Tue, 22 Jan 2019 14:51:43 +0000 Received: from VI1PR05MB4269.eurprd05.prod.outlook.com ([fe80::64cb:93f8:918:f1a1]) by VI1PR05MB4269.eurprd05.prod.outlook.com ([fe80::64cb:93f8:918:f1a1%6]) with mapi id 15.20.1537.031; Tue, 22 Jan 2019 14:51:43 +0000 From: Ali Alnubani To: "stable@dpdk.org" CC: Yongseok Koh Thread-Topic: [17.11] net/mlx5: fix initialization of struct members Thread-Index: AQHUsmH9BuJt/OgYj0eA88kqeunlMQ== Date: Tue, 22 Jan 2019 14:51:43 +0000 Message-ID: <20190122145059.31868-1-alialnu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.19.1 x-clientproxiedby: LO2P265CA0395.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::23) To VI1PR05MB4269.eurprd05.prod.outlook.com (2603:10a6:803:40::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=alialnu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB4719; 6:47HegjGUNRHn5z6wNHlBI9UEU+JYcbPMVRjbiOCZq+zqGaL0RxW8cRiV1Yd1vNu6xyUgg53vmzv1n/o3YCWLoanAfxwqR3Z1MaNW5djy9C3Doubd+CQHh4vaSZ6mHY3XY3vJx3LUP22nyszxy2dgT/gH9uO0kBr4KSy6tvCjmuBc3l0LI0is885OJAp0zmcd2lHqzezIoC3y40bcbq5rgmZvJ+IlDQMKjqO4UZfXShoYgVy5wUHmqVyuvY4pnMXPkF2tqoZyJIZEI3dNcrbcuXYVljJgFYtr98xgz3YgYv5CVtIoaSLqBdfHlzdb38N9KO9qDmJZRSpNstjg+pe6uwEvfMPZhT94v0P4+/BqP+9oXT3+peCGSHvzWBwERIUK9oc5HrDoHGyyDkhM0XvgyKUHhAMrOCoaqLuCc8Xbm/9/J1dO9Vt89m/I+6QLSx/kRo9qFBHMj/UykybDP2X4wA==; 5:o49n6x0J0axhMe20kDiA36qTEwFfTsTcdgY7NTfCF04nJF9fU0PND8NHFCEffV1P+pc+GhP/Hqnz66BXtRFLSBaiKkyjIdafZjYIr764nZQNSZi04mzxl+14ChjdlaQFNUh4Zxe5l9i3nnBWgW+fdBVoMLGAEJUl/w6OPGz2byvc54NIhhD5RG3IF51eilX0K35L2KEdL8JhW4YUF/cSYA==; 7:DgpPbj5BKMDgz7TGC9OHTmBQ0Dgwe3qT0RFkJXKJhAZzDEn/qLu0PCfGNi9oWBfLcvlNc5JbbSeedb6BAD/h0fkztXVZQCSGfHXAFxUQY14FY9S87DdNhULJ7ZrIWRT9mYYdbz+wyZU4ZyZuuOvkGw== x-ms-office365-filtering-correlation-id: 0ae2ac3b-473f-4cdd-c7fb-08d680791f72 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB4719; x-ms-traffictypediagnostic: VI1PR05MB4719: x-microsoft-antispam-prvs: x-forefront-prvs: 0925081676 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(366004)(396003)(346002)(39860400002)(189003)(199004)(26005)(7736002)(81156014)(1730700003)(186003)(1076003)(2501003)(102836004)(478600001)(14454004)(305945005)(50226002)(66066001)(316002)(68736007)(36756003)(5640700003)(81166006)(99286004)(6486002)(8676002)(6436002)(52116002)(8936002)(14444005)(256004)(386003)(6506007)(6916009)(2906002)(86362001)(6512007)(71200400001)(71190400001)(4326008)(476003)(2616005)(486006)(2351001)(107886003)(105586002)(53936002)(106356001)(25786009)(6116002)(3846002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB4719; H:VI1PR05MB4269.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qucqGMyZ6990Ay7IuSYPCHn/yFPIG21ZbEGe62+8SKjapQmBEr2Dd+0EghoZyyAfPAOBhOXD7lUkgngjkNj4Fj4who76xtYRVKPo71g+v5x1BtYlKshI35/y7QotXOnvm5mtLSX+OxOoLorUm0w4+WNxl2BmLz+x+/xOAP1kCZkp8VCF+8a0zahS8AZUNtfWQ4QZmDvVad82LhX3zYdONLWBKDTKfEKMwNzp54OBumazRkvTbToXt3QAVG5Dd00kF0qiGboM8JD7sVIiPLu1B7/wCXiYxcUcHARGhzOGUsx8snGvyxPrVOmzSdxbbWIvxatSZIXJhS+lg5rgiwEvdG5zd2k/eRbuxsRVel5o/dxoXhSYSOQDhMUM4ufJvdqErLVq2cw1vR8B5JCWOtZtxw6hzHhjZCZIV7Qh0rALa2Q= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ae2ac3b-473f-4cdd-c7fb-08d680791f72 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2019 14:51:42.2924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4719 Subject: [dpdk-stable] [17.11] net/mlx5: fix initialization of struct members X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 14:51:44 -0000 [ backported from upstream commit 0c15f3c010322853078c20a2a9926d3fb5986548 = ] This patch fixes compilation errors with meson and the clang compiler caused by some of the struct members not being initialized. ``` ../drivers/net/mlx5/mlx5_mr.c:345:37: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx5_mr_cache entry =3D { 0, }; ^ ../drivers/net/mlx5/mlx5_mr.c:389:36: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx5_mr_cache ret =3D { 0, }; ^ ../drivers/net/mlx5/mlx5_mr.c:691:35: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx5_mr_cache ret =3D { 0, }; ^ ``` The compilation errors reproduce with clang version 3.4.2 (tags/RELEASE_34/dot2-final) on RHEL. Fixes: 87011737b715 ("mlx5: add software counters") Signed-off-by: Ali Alnubani Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_stats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c index 345ed7075..e880d24c5 100644 --- a/drivers/net/mlx5/mlx5_stats.c +++ b/drivers/net/mlx5/mlx5_stats.c @@ -356,10 +356,11 @@ int mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) { struct priv *priv =3D dev->data->dev_private; - struct rte_eth_stats tmp =3D {0}; + struct rte_eth_stats tmp; unsigned int i; unsigned int idx; =20 + memset(&tmp, 0, sizeof(tmp)); /* Add software counters. */ for (i =3D 0; (i !=3D priv->rxqs_n); ++i) { struct mlx5_rxq_data *rxq =3D (*priv->rxqs)[i]; --=20 2.19.1