* [dpdk-stable] [PATCH 4/4] net/virtio-user: fix used ring update in cvq handling
[not found] <20190122170143.5650-1-tiwei.bie@intel.com>
@ 2019-01-22 17:01 ` Tiwei Bie
2019-01-23 22:08 ` Maxime Coquelin
0 siblings, 1 reply; 2+ messages in thread
From: Tiwei Bie @ 2019-01-22 17:01 UTC (permalink / raw)
To: maxime.coquelin, zhihong.wang, dev; +Cc: stable
When updating used ring, the id in used element should be the
index of the first desc in the desc chain.
Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device emulation")
Cc: stable@dpdk.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 89d287a74..d1157378d 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -722,7 +722,7 @@ virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx)
/* Update used ring */
uep = &vring->used->ring[avail_idx];
- uep->id = avail_idx;
+ uep->id = desc_idx;
uep->len = n_descs;
vring->used->idx++;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 4/4] net/virtio-user: fix used ring update in cvq handling
2019-01-22 17:01 ` [dpdk-stable] [PATCH 4/4] net/virtio-user: fix used ring update in cvq handling Tiwei Bie
@ 2019-01-23 22:08 ` Maxime Coquelin
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Coquelin @ 2019-01-23 22:08 UTC (permalink / raw)
To: Tiwei Bie, zhihong.wang, dev; +Cc: stable
On 1/22/19 6:01 PM, Tiwei Bie wrote:
> When updating used ring, the id in used element should be the
> index of the first desc in the desc chain.
>
> Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device emulation")
> Cc:stable@dpdk.org
>
> Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-23 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190122170143.5650-1-tiwei.bie@intel.com>
2019-01-22 17:01 ` [dpdk-stable] [PATCH 4/4] net/virtio-user: fix used ring update in cvq handling Tiwei Bie
2019-01-23 22:08 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).